From: bugzilla at busybox.net <bugzilla@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 10211] New: mkpasswd.c:183: pointless test ?
Date: Wed, 09 Aug 2017 20:23:46 +0000 [thread overview]
Message-ID: <bug-10211-163@https.bugs.busybox.net/> (raw)
https://bugs.busybox.net/show_bug.cgi?id=10211
Bug ID: 10211
Summary: mkpasswd.c:183: pointless test ?
Product: buildroot
Version: unspecified
Hardware: All
OS: Linux
Status: NEW
Severity: trivial
Priority: P5
Component: Other
Assignee: unassigned at buildroot.uclibc.org
Reporter: dcb314 at hotmail.com
CC: buildroot at uclibc.org
Target Milestone: ---
buildroot-2017.08-rc1/package/mkpasswd/mkpasswd.c:183]: (style) Checking if
unsigned variable 'rounds' is less than zero.
Source code is
rounds = strtol(optarg, &p, 10);
if (p == NULL || *p != '\0' || rounds < 0) {
Maybe a call to strtoul would be better ?
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2017-08-09 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 20:23 bugzilla at busybox.net [this message]
2018-01-10 22:08 ` [Buildroot] [Bug 10211] mkpasswd.c:183: pointless test ? bugzilla at busybox.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-10211-163@https.bugs.busybox.net/ \
--to=bugzilla@busybox.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.