From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 102342] mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition Date: Mon, 21 Aug 2017 16:56:02 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1229883716==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E4D66E2A6 for ; Mon, 21 Aug 2017 16:56:02 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1229883716== Content-Type: multipart/alternative; boundary="15033345620.Be3af0C.23702"; charset="UTF-8" --15033345620.Be3af0C.23702 Date: Mon, 21 Aug 2017 16:56:02 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D102342 Bug ID: 102342 Summary: mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache. c:169]: (style) Suspicious condition Product: Mesa Version: 17.1 Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: dcb314@hotmail.com QA Contact: dri-devel@lists.freedesktop.org mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if (!entry && (ret =3D pb_cache_is_buffer_compat(cur_entry, size, alignment, usage) > 0)) maybe better code if (!entry && ((ret =3D pb_cache_is_buffer_compat(cur_entry, size, alignment, usage)) > 0= )) --=20 You are receiving this mail because: You are the assignee for the bug.= --15033345620.Be3af0C.23702 Date: Mon, 21 Aug 2017 16:56:02 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 102342
Summary mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]:= (style) Suspicious condition
Product Mesa
Version 17.1
Hardware Other
OS All
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter dcb314@hotmail.com
QA Contact dri-devel@lists.freedesktop.org 

mesa-17.1.7/src/gallium/auxiliary/pipebuffer/pb_cache.c:169]: =
(style)
Suspicious condition (assignment + comparison); Clarify expression with
parentheses.

Source code is

      if (!entry && (ret =3D pb_cache_is_buffer_compat(cur_entry, s=
ize,
                                                     alignment, usage) >=
 0))

maybe better code

      if (!entry && ((ret =3D pb_cache_is_buffer_compat(cur_entry, =
size,
                                                     alignment, usage)) >=
; 0))

You are receiving this mail because:
  • You are the assignee for the bug.
= --15033345620.Be3af0C.23702-- --===============1229883716== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1229883716==--