From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 103107] [CI] igt@gem_ctx_param@invalid-param-[get|set] - Failed assertion: __gem_context_get_param(fd, &arg) == -22 Date: Thu, 11 Jan 2018 11:26:54 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1726667137==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 563C16E7B1 for ; Thu, 11 Jan 2018 11:26:54 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1726667137== Content-Type: multipart/alternative; boundary="15156700141.deA6.10418"; charset="UTF-8" --15156700141.deA6.10418 Date: Thu, 11 Jan 2018 11:26:54 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D103107 --- Comment #10 from Marta L=C3=B6fstedt --- I believe this issue started when the I915_CONTEXT_PARAM_PRIORITY was added. commit ac14fbd460d0ec16e7750e40dcd8199b0ff83d0a Author: Chris Wilson Date: Tue Oct 3 21:34:53 2017 +0100 drm/i915/scheduler: Support user-defined priorities so instead of hitting default case with -EINVAL return, in i915_gem_context_getparam_ioctl, I915_CONTEXT_PARAM_BANNABLE + 1 gives us I915_CONTEXT_PARAM_PRIORITY. So, we could just change I915_CONTEXT_PARAM_BANNABLE + 1 to I915_CONTEXT_PARAM_PRIORITY + 1, but there is a comment in the testcase: /* NOTE: This testcase intentionally tests for the next free parameter * to catch ABI extensions. Don't "fix" this testcase without adding all * the tests for the new param first. */ As strict interpretation of this gives that subtest for the missing I915_CONTEXT_PARAM_GTT_SIZE, I915_CONTEXT_PARAM_NO_ERROR_CAPTURE, I915_CONTEXT_PARAM_BANNABLE and I915_CONTEXT_PARAM_PRIORITY, needs to be ad= ded before changing this test. I.e. this testcase fails because there are niot testcases for all context params. --=20 You are receiving this mail because: You are the assignee for the bug.= --15156700141.deA6.10418 Date: Thu, 11 Jan 2018 11:26:54 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 10 on bug 10310= 7 from Marta L=C3=B6fstedt 
I believe this issue started when the I915_CONTEXT_PARAM_PRIOR=
ITY was added.

commit ac14fbd460d0ec16e7750e40dcd8199b0ff83d0a
Author: Chris Wilson <ch=
ris@chris-wilson.co.uk>
Date:   Tue Oct 3 21:34:53 2017 +0100

    drm/i915/scheduler: Support user-defined priorities

so instead of hitting default case with -EINVAL return, in
i915_gem_context_getparam_ioctl,  I915_CONTEXT_PARAM_BANNABLE + 1 gives us
I915_CONTEXT_PARAM_PRIORITY.

So, we could just change I915_CONTEXT_PARAM_BANNABLE + 1 to
I915_CONTEXT_PARAM_PRIORITY + 1, but there is a comment in the testcase:

/* NOTE: This testcase intentionally tests for the next free parameter
 * to catch ABI extensions. Don't "fix" this testcase without add=
ing all
 * the tests for the new param first.
 */

As strict interpretation of this gives that subtest for the missing
I915_CONTEXT_PARAM_GTT_SIZE, I915_CONTEXT_PARAM_NO_ERROR_CAPTURE,
I915_CONTEXT_PARAM_BANNABLE and I915_CONTEXT_PARAM_PRIORITY, needs to be ad=
ded
before changing this test. I.e. this testcase fails because there are niot
testcases for all context params.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15156700141.deA6.10418-- --===============1726667137== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1726667137==--