From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 103389] [regression, bisected] Bad flickering of items in steam Date: Sat, 21 Oct 2017 10:39:36 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0924683449==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 181F26E106 for ; Sat, 21 Oct 2017 10:39:36 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0924683449== Content-Type: multipart/alternative; boundary="15085823760.6AA39.26483"; charset="UTF-8" --15085823760.6AA39.26483 Date: Sat, 21 Oct 2017 10:39:36 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D103389 Bug ID: 103389 Summary: [regression, bisected] Bad flickering of items in steam Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: gr.muench@gmail.com QA Contact: dri-devel@lists.freedesktop.org Created attachment 134972 --> https://bugs.freedesktop.org/attachment.cgi?id=3D134972&action=3Dedit regressed steam menu Steam has some very bad flickering of menu items in latest mesa git.=20 OpenGL renderer string: AMD Radeon HD 7900 Series (TAHITI / DRM 3.23.0 / 4.13.0-2-amd-staging-drm-next-git, LLVM 6.0.0) OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.3.0-devel (git-0fdd531457) Bisected to: 2f4705afde707e8eb41b9414c25df91aa1ea2fb3 is the first bad commit commit 2f4705afde707e8eb41b9414c25df91aa1ea2fb3 Author: Marek Ol=C5=A1=C3=A1k Date: Sun Oct 8 03:44:07 2017 +0200 radeonsi: if there's just const buffer 0, set it in place of CONST/SSBO pointer SI_SGPR_CONST_AND_SHADER_BUFFERS now contains the pointer to const buff= er 0 if there is no other buffer there. Benefits: - there is no constbuf descriptor upload and shader load It's assumed that all constant addresses are within bounds. Non-constant addresses are clamped against the last declared CONST variable. This only works if the state tracker ensures the bound constant buffer matches what the shader needs. Once we get 32-bit pointers, we can only do this for user constant buff= ers where the driver is in charge of the upload so that it can guarantee a 32-bit address. The real performance benefit might not be measurable. These apps get 100% theoretical benefit in all shaders (except where noted): - antichamber - barman arkham origins - borderlands 2 - borderlands pre-sequel - brutal legend - civilization BE - CS:GO - deadcore - dota 2 -- most shaders - europa universalis - grid autosport -- most shaders - left 4 dead 2 - legend of grimrock - life is strange - payday 2 - portal - rocket league - serious sam 3 bfe - talos principle - team fortress 2 - thea - unigine heaven - unigine valley -- also sanctuary and tropics - wasteland 2 - xcom: enemy unknown & enemy within - tesseract - unity (engine) Changed stats only: SGPRS: 2059998 -> 2086238 (1.27 %) VGPRS: 1626888 -> 1626904 (0.00 %) Spilled SGPRs: 7902 -> 7865 (-0.47 %) Code Size: 60924520 -> 60982660 (0.10 %) bytes Max Waves: 374539 -> 374526 (-0.00 %) Reviewed-by: Nicolai H=C3=A4hnle :040000 040000 7b660ccfb110c80ecd9b3d2f7f06ace5380cb76f d8ddc8515150a84131e566c4ddafb05d3d7be0a7 M src Confirmed bad commit by reverting it. --=20 You are receiving this mail because: You are the assignee for the bug.= --15085823760.6AA39.26483 Date: Sat, 21 Oct 2017 10:39:36 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 103389
Summary [regression, bisected] Bad flickering of items in steam
Product Mesa
Version git
Hardware Other
OS All
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter gr.muench@gmail.com
QA Contact dri-devel@lists.freedesktop.org 

Created attachment 134972 [details]
regressed steam menu

Steam has some very bad flickering of menu items in latest mesa git.=20

OpenGL renderer string: AMD Radeon HD 7900 Series (TAHITI / DRM 3.23.0 /
4.13.0-2-amd-staging-drm-next-git, LLVM 6.0.0)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.3.0-devel
(git-0fdd531457)

Bisected to:

2f4705afde707e8eb41b9414c25df91aa1ea2fb3 is the first bad commit
commit 2f4705afde707e8eb41b9414c25df91aa1ea2fb3
Author: Marek Ol=C5=A1=C3=A1k <marek.olsak@amd.com>
Date:   Sun Oct 8 03:44:07 2017 +0200

    radeonsi: if there's just const buffer 0, set it in place of CONST/SSBO
pointer

    SI_SGPR_CONST_AND_SHADER_BUFFERS now contains the pointer to const buff=
er 0
    if there is no other buffer there.

    Benefits:
    - there is no constbuf descriptor upload and shader load

    It's assumed that all constant addresses are within bounds. Non-constant
    addresses are clamped against the last declared CONST variable.
    This only works if the state tracker ensures the bound constant buffer
    matches what the shader needs.

    Once we get 32-bit pointers, we can only do this for user constant buff=
ers
    where the driver is in charge of the upload so that it can guarantee a
32-bit
    address.

    The real performance benefit might not be measurable.

    These apps get 100% theoretical benefit in all shaders (except where
noted):
    - antichamber
    - barman arkham origins
    - borderlands 2
    - borderlands pre-sequel
    - brutal legend
    - civilization BE
    - CS:GO
    - deadcore
    - dota 2 -- most shaders
    - europa universalis
    - grid autosport -- most shaders
    - left 4 dead 2
    - legend of grimrock
    - life is strange
    - payday 2
    - portal
    - rocket league
    - serious sam 3 bfe
    - talos principle
    - team fortress 2
    - thea
    - unigine heaven
    - unigine valley -- also sanctuary and tropics
    - wasteland 2
    - xcom: enemy unknown & enemy within
    - tesseract
    - unity (engine)

    Changed stats only:
        SGPRS: 2059998 -> 2086238 (1.27 %)
        VGPRS: 1626888 -> 1626904 (0.00 %)
        Spilled SGPRs: 7902 -> 7865 (-0.47 %)
        Code Size: 60924520 -> 60982660 (0.10 %) bytes
        Max Waves: 374539 -> 374526 (-0.00 %)

    Reviewed-by: Nicolai H=C3=A4hnle <nicolai.haehnle@amd.com>

:040000 040000 7b660ccfb110c80ecd9b3d2f7f06ace5380cb76f
d8ddc8515150a84131e566c4ddafb05d3d7be0a7 M      src


Confirmed bad commit by reverting it.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15085823760.6AA39.26483-- --===============0924683449== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0924683449==--