From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows. Date: Tue, 27 Feb 2018 23:55:30 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1215765074==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 0288C6E814 for ; Tue, 27 Feb 2018 23:55:30 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1215765074== Content-Type: multipart/alternative; boundary="15197757290.dDe57aDB.24642" Content-Transfer-Encoding: 7bit --15197757290.dDe57aDB.24642 Date: Tue, 27 Feb 2018 23:55:29 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D105282 Bug ID: 105282 Summary: Divinity: Original Sin Enhanced Edition blocky and jagged shadows. Product: Mesa Version: 17.3 Hardware: All OS: Linux (All) Status: NEW Severity: enhancement Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: e.singularitycat@gmail.com QA Contact: dri-devel@lists.freedesktop.org After working around the bugs described in #93551 and getting the game runn= ing, I noticed that unless the shadow quality setting was at "Ultra", all render= ed shadows are blocky and jagged, with gaps appearing between the shadows cast= be apparently solid objects. I messed around with some driconf options, and discovered that this renderi= ng issue goes away if setting the "glsl_correct_derivatives_after_discard" opt= ion. Unfortunately, I couldn't get a working apitrace because of the LD_PRELOAD hacks, but attached are two screenshots of roughly the same area, one witho= ut the option (before.png) and one with (after.png). --=20 You are receiving this mail because: You are the assignee for the bug.= --15197757290.dDe57aDB.24642 Date: Tue, 27 Feb 2018 23:55:29 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 105282
Summary Divinity: Original Sin Enhanced Edition blocky and jagged sha= dows.
Product Mesa
Version 17.3
Hardware All
OS Linux (All)
Status NEW
Severity enhancement
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter e.singularitycat@gmail.com
QA Contact dri-devel@lists.freedesktop.org 

After working around the bugs described in #93551 and getting =
the game running,
I noticed that unless the shadow quality setting was at "Ultra", =
all rendered
shadows are blocky and jagged, with gaps appearing between the shadows cast=
 be
apparently solid objects.

I messed around with some driconf options, and discovered that this renderi=
ng
issue goes away if setting the "glsl_correct_derivatives_after_discard=
" option.

Unfortunately, I couldn't get a working apitrace because of the LD_PRELOAD
hacks, but attached are two screenshots of roughly the same area, one witho=
ut
the option (before.png) and one with (after.png).

You are receiving this mail because:
  • You are the assignee for the bug.
= --15197757290.dDe57aDB.24642-- --===============1215765074== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1215765074==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows. Date: Tue, 27 Feb 2018 23:56:41 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1922333999==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DE7A6E862 for ; Tue, 27 Feb 2018 23:56:41 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1922333999== Content-Type: multipart/alternative; boundary="15197758010.01Fc.23911" Content-Transfer-Encoding: 7bit --15197758010.01Fc.23911 Date: Tue, 27 Feb 2018 23:56:40 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D105282 --- Comment #1 from Elliot Thomas --- Created attachment 137676 --> https://bugs.freedesktop.org/attachment.cgi?id=3D137676&action=3Dedit Without "glsl_correct_derivatives_after_discard" --=20 You are receiving this mail because: You are the assignee for the bug.= --15197758010.01Fc.23911 Date: Tue, 27 Feb 2018 23:56:41 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 1 on bug 10528= 2 from Elliot Thomas 
Created attachment 137676 [details]
Without "glsl_correct_derivatives_after_discard"

You are receiving this mail because:
  • You are the assignee for the bug.
= --15197758010.01Fc.23911-- --===============1922333999== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1922333999==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows. Date: Tue, 27 Feb 2018 23:57:14 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1675616719==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 538C66E814 for ; Tue, 27 Feb 2018 23:57:14 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1675616719== Content-Type: multipart/alternative; boundary="15197758340.DdFdBbde.23909" Content-Transfer-Encoding: 7bit --15197758340.DdFdBbde.23909 Date: Tue, 27 Feb 2018 23:57:14 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D105282 --- Comment #2 from Elliot Thomas --- Created attachment 137677 --> https://bugs.freedesktop.org/attachment.cgi?id=3D137677&action=3Dedit With "glsl_correct_derivatives_after_discard" --=20 You are receiving this mail because: You are the assignee for the bug.= --15197758340.DdFdBbde.23909 Date: Tue, 27 Feb 2018 23:57:14 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 2 on bug 10528= 2 from Elliot Thomas 
Created attachment 137677 [details]
With "glsl_correct_derivatives_after_discard"

You are receiving this mail because:
  • You are the assignee for the bug.
= --15197758340.DdFdBbde.23909-- --===============1675616719== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1675616719==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 105282] Divinity: Original Sin Enhanced Edition blocky and jagged shadows. Date: Mon, 05 Aug 2019 05:36:34 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2065878679==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 20E4189DA8 for ; Mon, 5 Aug 2019 05:36:34 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2065878679== Content-Type: multipart/alternative; boundary="15649833940.baD04DfB.22451" Content-Transfer-Encoding: 7bit --15649833940.baD04DfB.22451 Date: Mon, 5 Aug 2019 05:36:34 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D105282 Timothy Arceri changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Timothy Arceri --- Should be fixed by: commit 3c9144f9e5888e9a31886b64168f63e991da01d0 Author: Timothy Arceri Date: Fri Aug 2 10:05:20 2019 +1000 drirc: Add discard workaround for Divinity: Original Sin EE This adds an additional work around for the game to fix the blocky shadows as reported in bug 105282 Acked-by: Eric Engestrom Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D105282 --=20 You are receiving this mail because: You are the assignee for the bug.= --15649833940.baD04DfB.22451 Date: Mon, 5 Aug 2019 05:36:34 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Timothy Arceri changed bug 10528= 2
What Removed Added
Resolution --- FIXED
Status NEW RESOLVED

Commen= t # 3 on bug 10528= 2 from Timothy Arceri 
Should be fixed by:

commit 3c9144f9e5888e9a31886b64168f63e991da01d0
Author: Timothy Arceri <tar=
ceri@itsqueeze.com>
Date:   Fri Aug 2 10:05:20 2019 +1000

    drirc: Add discard workaround for Divinity: Original Sin EE

    This adds an additional work around for the game to fix the blocky
    shadows as reported in bug 105282

    Acked-by: Eric Engestrom <eric.engestrom@intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.=
cgi?id=3D105282

You are receiving this mail because:
  • You are the assignee for the bug.
= --15649833940.baD04DfB.22451-- --===============2065878679== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============2065878679==--