From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 107012] [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el] Date: Sat, 23 Jun 2018 21:34:48 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1732940001==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id BE33D6E05E for ; Sat, 23 Jun 2018 21:34:48 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1732940001== Content-Type: multipart/alternative; boundary="15297896880.4004e6.32702" Content-Transfer-Encoding: 7bit --15297896880.4004e6.32702 Date: Sat, 23 Jun 2018 21:34:48 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D107012 Bug ID: 107012 Summary: [PATCH] Radeon SI driver not architecture safe, crashes on ppc64[el] Product: Mesa Version: git Hardware: PowerPC OS: All Status: NEW Severity: major Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: tpearson@raptorengineering.com QA Contact: dri-devel@lists.freedesktop.org Created attachment 140294 --> https://bugs.freedesktop.org/attachment.cgi?id=3D140294&action=3Dedit Fix crashes color_interp_vgpr_index was declared as a generic char value. Because sign= ed values are used in this variable, the result was not safe across architectu= res and crashed on ppc64[el] and arm systems. The atttached patch declares color_interp_vgpr_index as a signed type, and = has been verified to work with alien-arena, glxgears, and Flightgear, all of wh= ich were crashing before the patch. --=20 You are receiving this mail because: You are the assignee for the bug.= --15297896880.4004e6.32702 Date: Sat, 23 Jun 2018 21:34:48 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 107012
Summary [PATCH] Radeon SI driver not architecture safe, crashes on pp= c64[el]
Product Mesa
Version git
Hardware PowerPC
OS All
Status NEW
Severity major
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter tpearson@raptorengineering.com
QA Contact dri-devel@lists.freedesktop.org 

Created attachment 140294 [d=
etails] [review]
Fix crashes

color_interp_vgpr_index was declared as a generic char value.  Because sign=
ed
values are used in this variable, the result was not safe across architectu=
res
and crashed on ppc64[el] and arm systems.

The atttached patch declares color_interp_vgpr_index as a signed type, and =
has
been verified to work with alien-arena, glxgears, and Flightgear, all of wh=
ich
were crashing before the patch.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15297896880.4004e6.32702-- --===============1732940001== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1732940001==--