From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 108917] gamma adjustments cause stuttering with amdgpu.dc=1, especially problematic with RedShift etc. Date: Wed, 11 Sep 2019 13:36:51 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0266993835==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id D70EC6EB05 for ; Wed, 11 Sep 2019 13:36:51 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0266993835== Content-Type: multipart/alternative; boundary="15682090111.89de5e.11866" Content-Transfer-Encoding: 7bit --15682090111.89de5e.11866 Date: Wed, 11 Sep 2019 13:36:51 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D108917 --- Comment #15 from tempel.julian@gmail.com --- To clarify: There is no connection to any compositor. You can also reproduce the issue with any desktop environment where you can disable the compositor. Instead of using a compositor then, simply enable TearFree and run "redshif= t -t 4500:4500 -l 1:1". -> It still makes everything stutter. And not just with cursor input, it affects the whole screen content without further doing. Just look at your browser window content of www.vsnctester.com, scroll on any webpage or play= a video: The stutter should always be noticeable. The commit "drm/amd/display: Allow cursor async updates for framebuffer swa= ps" has not changed the situation. I can't explain why this issue was less distinct with some 5.1 kernel versi= ons. Anyway: It's back to "really stuttery" since 5.2. --- Is this perhaps because userspace uses legacy gamma adjustment instead of n= ew atomic infrastructure? In that case, it would seem unrealistic to expect it= to adopt to the new infrastructure if not even Gnome Nightlight on Wayland uses it. So a performance fix for legacy gamma adjustments would be highly welco= me (if my assumptions apply ;) ). I also wonder why there has to be stutter at all. Only the initial setting = of new gamma adjustments cause the stutter. When you run redshift in "oneshot" mode via "redshift -O 4500", there is no more stutter once the initial adjustment is done and the gamma stays adjusted. Perhaps it would help to make the kernel delay the adjustments until they c= an happen without causing performance issues with vsync + pageflipping? --=20 You are receiving this mail because: You are the assignee for the bug.= --15682090111.89de5e.11866 Date: Wed, 11 Sep 2019 13:36:51 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 15 on bug 10891= 7 from tempel.j= ulian@gmail.com
To clarify: There is no connection to any compositor. You can =
also reproduce
the issue with any desktop environment where you can disable the compositor.
Instead of using a compositor then, simply enable TearFree and run "re=
dshift -t
4500:4500 -l 1:1".
-> It still makes everything stutter. And not just with cursor input, it
affects the whole screen content without further doing. Just look at your
browser window content of www.vsnctester.com, scroll on any webpage or play=
 a
video: The stutter should always be noticeable.
The commit "drm/amd/display: Allow cursor async updates for framebuffe=
r swaps"
has not changed the situation.

I can't explain why this issue was less distinct with some 5.1 kernel versi=
ons.
Anyway: It's back to "really stuttery" since 5.2.

---

Is this perhaps because userspace uses legacy gamma adjustment instead of n=
ew
atomic infrastructure? In that case, it would seem unrealistic to expect it=
 to
adopt to the new infrastructure if not even Gnome Nightlight on Wayland uses
it. So a performance fix for legacy gamma adjustments would be highly welco=
me
(if my assumptions apply ;) ).

I also wonder why there has to be stutter at all. Only the initial setting =
of
new gamma adjustments cause the stutter. When you run redshift in "one=
shot"
mode via "redshift -O 4500", there is no more stutter once the in=
itial
adjustment is done and the gamma stays adjusted.
Perhaps it would help to make the kernel delay the adjustments until they c=
an
happen without causing performance issues with vsync + pageflipping?


You are receiving this mail because:
  • You are the assignee for the bug.
= --15682090111.89de5e.11866-- --===============0266993835== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0266993835==--