From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h Date: Fri, 14 Dec 2018 00:05:31 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1808916735==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 44A726E01D for ; Fri, 14 Dec 2018 00:05:31 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1808916735== Content-Type: multipart/alternative; boundary="15447459310.AdBFF5.18203" Content-Transfer-Encoding: 7bit --15447459310.AdBFF5.18203 Date: Fri, 14 Dec 2018 00:05:31 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109060 Bug ID: 109060 Summary: android-x86 64bit builds crashes due to android/gralloc_handle.h Product: DRI Version: DRI git Hardware: x86-64 (AMD64) OS: other Status: NEW Severity: blocker Priority: medium Component: libdrm Assignee: dri-devel@lists.freedesktop.org Reporter: issor.oruam@gmail.com Created attachment 142809 --> https://bugs.freedesktop.org/attachment.cgi?id=3D142809&action=3Dedit draft patch that solves the crashes Hi, there is a series of Android apps using 32bit libs on 64bit Android that are crashing (Jackpal terminal, Sky Force, Olympus Rising, Vulkan V1, 3dmark benchmarks and many others) The cause is the difference in size of gralloc handle structs created by 32= bit libraries and 64bit architetures libraries. The problem was observed and patched in gbm_gralloc in the past by Chih-Wei Huang, but it was not taken into account in later evolution, now with android/gralloc_handle.h in libdrm the problem is again present, because the handle sizes in 32bit and 64bit are again different. The attached draft patch solves the issue, tested on all apps that were crashing Please review and provide feedback Mauro --=20 You are receiving this mail because: You are the assignee for the bug.= --15447459310.AdBFF5.18203 Date: Fri, 14 Dec 2018 00:05:31 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 109060
Summary android-x86 64bit builds crashes due to android/gralloc_handl= e.h
Product DRI
Version DRI git
Hardware x86-64 (AMD64)
OS other
Status NEW
Severity blocker
Priority medium
Component libdrm
Assignee dri-devel@lists.freedesktop.org
Reporter issor.oruam@gmail.com 

Created atta=
chment 142809 [details] [=
review]
draft patch that solves the crashes

Hi,
there is a series of Android apps using 32bit libs on 64bit Android that are
crashing (Jackpal terminal, Sky Force, Olympus Rising, Vulkan V1, 3dmark
benchmarks and many others)

The cause is the difference in size of gralloc handle structs created by 32=
bit
libraries and 64bit architetures libraries.

The problem was observed and patched in gbm_gralloc in the past by Chih-Wei
Huang, but it was not taken into account in later evolution,
now with android/gralloc_handle.h in libdrm the problem is again present,
because the handle sizes in 32bit and 64bit are again different.

The attached draft patch solves the issue, tested on all apps that were
crashing
Please review and provide feedback

Mauro

You are receiving this mail because:
  • You are the assignee for the bug.
= --15447459310.AdBFF5.18203-- --===============1808916735== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1808916735==--