From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 109587] "xf86drm: Add drmIsMaster()" commit breaks X server builds Date: Fri, 08 Feb 2019 11:59:12 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0589944475==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 31EA56EDA8 for ; Fri, 8 Feb 2019 11:59:12 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0589944475== Content-Type: multipart/alternative; boundary="15496271521.5b2a3E.32348" Content-Transfer-Encoding: 7bit --15496271521.5b2a3E.32348 Date: Fri, 8 Feb 2019 11:59:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D109587 Bug ID: 109587 Summary: "xf86drm: Add drmIsMaster()" commit breaks X server builds Product: DRI Version: XOrg git Hardware: All OS: All Status: NEW Severity: major Priority: medium Component: libdrm Assignee: dri-devel@lists.freedesktop.org Reporter: eero.t.tamminen@intel.com Following commit: ----------------------------------------------- commit 17dfe3ac93217b43f93bc81d1129bd38a89d0368 Author: Christopher James Halse Rogers AuthorDate: Wed Jan 23 15:38:45 2019 +1100 Commit: Emil Velikov CommitDate: Thu Feb 7 17:43:01 2019 +0000 xf86drm: Add drmIsMaster() ... --- a/xf86drm.h +++ b/xf86drm.h @@ -37,6 +37,7 @@ #include #include #include +#include ----------------------------------------------- Breaks X server build: ----------------------------------------------- FAILED: hw/xfree86/dri2/xorg_dri2@sta/dri2.c.o ... In file included from /path/to/include/xf86drm.h:40:0, from /path/to/hw/xfree86/dri2/dri2.c:39: /path/to/hw/xfree86/common/xf86Opt.h:44:10: error: two or more data types in declaration specifiers Bool bool; ^ In file included from /path/to/hw/xfree86/common/xf86str.h:43:0, from /path/to/hw/xfree86/common/xf86.h:44, from /path/to/hw/xfree86/dri2/dri2.c:48: /path/to/hw/xfree86/common/xf86Opt.h:44:14: warning: declaration does not declare anything Bool bool; ^ ----------------------------------------------- Because couple of structures in X source code are using struct members name= d as "bool" (added in 2012): ./hw/xfree86/common/xf86Opt.h: Bool bool; ./hw/xwin/winconfig.h: Bool bool; (FYI: Bool is defined as "int" in several X headers.) Please revert the part adding "stdbool.h" include / "bool" typedef to the xf86drm.h header used by X server, until somebody renames those badly named struct members in X server sources. --=20 You are receiving this mail because: You are the assignee for the bug.= --15496271521.5b2a3E.32348 Date: Fri, 8 Feb 2019 11:59:12 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 109587
Summary "xf86drm: Add drmIsMaster()" commit breaks X server= builds
Product DRI
Version XOrg git
Hardware All
OS All
Status NEW
Severity major
Priority medium
Component libdrm
Assignee dri-devel@lists.freedesktop.org
Reporter eero.t.tamminen@intel.com 

Following commit:
-----------------------------------------------
commit 17dfe3ac93217b43f93bc81d1129bd38a89d0368
Author:     Christopher James Halse Rogers
<christoph=
er.halse.rogers@canonical.com>
AuthorDate: Wed Jan 23 15:38:45 2019 +1100
Commit:     Emil Velikov <emil.l.velikov@gmail.com>
CommitDate: Thu Feb 7 17:43:01 2019 +0000

    xf86drm: Add drmIsMaster()
...
--- a/xf86drm.h
+++ b/xf86drm.h
@@ -37,6 +37,7 @@
 #include <stdarg.h>
 #include <sys/types.h>
 #include <stdint.h>
+#include <stdbool.h>
-----------------------------------------------

Breaks X server build:
-----------------------------------------------
FAILED: hw/xfree86/dri2/xorg_dri2@sta/dri2.c.o
...
In file included from /path/to/include/xf86drm.h:40:0,
                 from /path/to/hw/xfree86/dri2/dri2.c:39:
/path/to/hw/xfree86/common/xf86Opt.h:44:10: error: two or more data types in
declaration specifiers
     Bool bool;
          ^
In file included from /path/to/hw/xfree86/common/xf86str.h:43:0,
                 from /path/to/hw/xfree86/common/xf86.h:44,
                 from /path/to/hw/xfree86/dri2/dri2.c:48:
/path/to/hw/xfree86/common/xf86Opt.h:44:14: warning: declaration does not
declare anything
     Bool bool;
              ^
-----------------------------------------------

Because couple of structures in X source code are using struct members name=
d as
"bool" (added in 2012):
./hw/xfree86/common/xf86Opt.h:    Bool bool;
./hw/xwin/winconfig.h:    Bool bool;

(FYI: Bool is defined as "int" in several X headers.)

Please revert the part adding "stdbool.h" include / "bool&qu=
ot; typedef to the
xf86drm.h header used by X server, until somebody renames those badly named
struct members in X server sources.

You are receiving this mail because:
  • You are the assignee for the bug.
= --15496271521.5b2a3E.32348-- --===============0589944475== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0589944475==--