From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 110963] Wrong condition and wrong variable substitution in libgl1-amdgpu-mesa-dri in postinst script Date: Sat, 22 Jun 2019 03:32:18 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1035005925==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FCD76E951 for ; Sat, 22 Jun 2019 03:32:18 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1035005925== Content-Type: multipart/alternative; boundary="15611743381.316ff.2715" Content-Transfer-Encoding: 7bit --15611743381.316ff.2715 Date: Sat, 22 Jun 2019 03:32:18 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D110963 Bug ID: 110963 Summary: Wrong condition and wrong variable substitution in libgl1-amdgpu-mesa-dri in postinst script Product: DRI Version: unspecified Hardware: Other OS: All Status: NEW Severity: major Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel@lists.freedesktop.org Reporter: ashark@linuxcomp.ru 19.20-812932 release for Ubuntu In libgl1-amdgpu-mesa-dri in postinst script there is such condition: # Support I+A hybrid graphics=20 if [ -f ... ] && [ "str1" !=3D "str2" ]; then You just compare two different strings? I guess you wanted to compare folder contents. But now that second condition will always be true. Further there is: if [ "${f%%/*}" =3D ... ]; then there is extra percent symbol, you should remove it. Btw, in rpm release variant in scriptlet there is no such mistake. --=20 You are receiving this mail because: You are the assignee for the bug.= --15611743381.316ff.2715 Date: Sat, 22 Jun 2019 03:32:18 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 110963
Summary Wrong condition and wrong variable substitution in libgl1-amd= gpu-mesa-dri in postinst script
Product DRI
Version unspecified
Hardware Other
OS All
Status NEW
Severity major
Priority medium
Component DRM/AMDgpu-pro
Assignee dri-devel@lists.freedesktop.org
Reporter ashark@linuxcomp.ru

19.20-812932 release for Ubuntu

In libgl1-amdgpu-mesa-dri in postinst script there is such condition:
    # Support I+A hybrid graphics=20
    if [ -f ... ] && [ "str1" !=3D "str2" ]; th=
en
You just compare two different strings? I guess you wanted to compare folder
contents. But now that second condition will always be true.

Further there is:
    if [ "${f%%/*}" =3D ... ]; then
there is extra percent symbol, you should remove it. Btw, in rpm release
variant in scriptlet there is no such mistake.


You are receiving this mail because:
  • You are the assignee for the bug.
= --15611743381.316ff.2715-- --===============1035005925== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1035005925==--