From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 111122] 2500U: Graphics corruption on kernel 5.2 Date: Sun, 18 Aug 2019 02:18:23 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0670214610==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 802FB6E574 for ; Sun, 18 Aug 2019 02:18:23 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0670214610== Content-Type: multipart/alternative; boundary="15660947035.4E995ac20.32461" Content-Transfer-Encoding: 7bit --15660947035.4E995ac20.32461 Date: Sun, 18 Aug 2019 02:18:23 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D111122 --- Comment #20 from Brian Schott --- The following applies to the graphics corruption seen in Dolphin: ea5b7de138bb7e9a4e7e4f0c39c4ceb16acae923 is the first bad commit commit ea5b7de138bb7e9a4e7e4f0c39c4ceb16acae923 Author: Pierre-Eric Pelloux-Prayer Date: Wed Jul 3 19:27:12 2019 +0200 radeonsi: make gl_SampleMaskIn =3D 0x1 when MSAA is disabled gl_SampleMaskIn is 1 when R_028BE0_PA_SC_AA_CONFIG is 0, so this commit rework the conditions controlling this register. Before it was set if the sctx->framebuffer had a sample count > 1. Now we still require this condition, but we also need either: - GL_MULTISAMPLE to be enabled - to be executing an operation that doesn't depends on GL state using u_blitter. This fixes the arb_sample_shading/sample_mask piglit tests on radeonsi. Signed-off-by: Marek Ol=C5=A1=C3=A1k src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.= --15660947035.4E995ac20.32461 Date: Sun, 18 Aug 2019 02:18:23 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Comme= nt # 20 on bug 11112= 2 from Brian Schott 
The following applies to the graphics corruption seen in Dolph=
in:

ea5b7de138bb7e9a4e7e4f0c39c4ceb16acae923 is the first bad commit
commit ea5b7de138bb7e9a4e7e4f0c39c4ceb16acae923
Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Date:   Wed Jul 3 19:27:12 2019 +0200

    radeonsi: make gl_SampleMaskIn =3D 0x1 when MSAA is disabled

    gl_SampleMaskIn is 1 when R_028BE0_PA_SC_AA_CONFIG is 0, so this commit
rework the conditions
    controlling this register.

    Before it was set if the sctx->framebuffer had a sample count > 1.

    Now we still require this condition, but we also need either:
      - GL_MULTISAMPLE to be enabled
      - to be executing an operation that doesn't depends on GL state using
u_blitter.

    This fixes the arb_sample_shading/sample_mask piglit tests on radeonsi.

    Signed-off-by: Marek Ol=C5=A1=C3=A1k <marek.olsak@amd.com>

 src/gallium/drivers/radeonsi/si_state.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

You are receiving this mail because:
  • You are the assignee for the bug.
= --15660947035.4E995ac20.32461-- --===============0670214610== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0670214610==--