From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 111402] amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included] Date: Wed, 14 Aug 2019 19:04:21 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0750659450==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E3AC6E816 for ; Wed, 14 Aug 2019 19:04:21 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0750659450== Content-Type: multipart/alternative; boundary="15658094611.7ea2.9913" Content-Transfer-Encoding: 7bit --15658094611.7ea2.9913 Date: Wed, 14 Aug 2019 19:04:21 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D111402 Bug ID: 111402 Summary: amdgpu-pro-install fails to install on openSUSE Leap 15.1 due to insufficient checks of $ID [PATCH included] Product: DRI Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: DRM/AMDgpu-pro Assignee: dri-devel@lists.freedesktop.org Reporter: public_timo.s@silentcreek.de Created attachment 145064 --> https://bugs.freedesktop.org/attachment.cgi?id=3D145064&action=3Dedit Simple fix that allows installing on openSUSE Leap 15.1 Hi, I downloaded the latest amdgpu-pro-19.30-844693-sle-15.tar.xz package from amd.com and tried to install it on openSUSE Leap 15.1 following the docs [1= ]. The command $ ./amdgpu-pro-install --opencl=3Dlegacy --headless failed with the following error: tee: /etc/yum.repos.d/amdgpu-pro-local.repo: No such file or directory So, the installer seems to mistake my system for a RHEL/CentOS-based OS. Looking at the code, I noticed the script gets the $ID from /etc/os-release which in my case looks like this: NAME=3D"openSUSE Leap" VERSION=3D"15.1 " ID=3D"opensuse-leap" [...] The function yum_repo() in the script does not properly check the $ID, howe= ver. It only matches against the strings 'sles', 'sled' and 'opensuse', but not 'opensuse-leap'. This is contrary to the function os_release() which matches opensuse-leap as well (with a wildcard). So, the solution to the issue is a simple wildcard. I'm attaching a patch t= hat allowed me to run the installer on openSUSE Leap 15.1. Regards, Timo [1] https://amdgpu-install.readthedocs.io/en/latest/install-installing.html --=20 You are receiving this mail because: You are the assignee for the bug.= --15658094611.7ea2.9913 Date: Wed, 14 Aug 2019 19:04:21 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 111402
Summary amdgpu-pro-install fails to install on openSUSE Leap 15.1 due= to insufficient checks of $ID [PATCH included]
Product DRI
Version unspecified
Hardware x86-64 (AMD64)
OS Linux (All)
Status NEW
Severity normal
Priority medium
Component DRM/AMDgpu-pro
Assignee dri-devel@lists.freedesktop.org
Reporter public_timo.s@silentcreek.de 

Created attachment 145064 [details] [review]
Simple fix that allows installing on openSUSE Leap 15.1

Hi,

I downloaded the latest amdgpu-pro-19.30-844693-sle-15.tar.xz package from
amd.com and tried to install it on openSUSE Leap 15.1 following the docs [1=
].

The command
  $ ./amdgpu-pro-install --opencl=3Dlegacy --headless
failed with the following error:
  tee: /etc/yum.repos.d/amdgpu-pro-local.repo: No such file or directory

So, the installer seems to mistake my system for a RHEL/CentOS-based OS.

Looking at the code, I noticed the script gets the $ID from /etc/os-release
which in my case looks like this:
NAME=3D"openSUSE Leap"
VERSION=3D"15.1 "
ID=3D"opensuse-leap"
[...]

The function yum_repo() in the script does not properly check the $ID, howe=
ver.
It only matches against the strings 'sles', 'sled' and 'opensuse', but not
'opensuse-leap'. This is contrary to the function os_release() which matches
opensuse-leap as well (with a wildcard).

So, the solution to the issue is a simple wildcard. I'm attaching a patch t=
hat
allowed me to run the installer on openSUSE Leap 15.1.

Regards,

Timo


[1] https://amdgpu-install.readthedocs.io/en/latest/install-instal=
ling.html

You are receiving this mail because:
  • You are the assignee for the bug.
= --15658094611.7ea2.9913-- --===============0750659450== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0750659450==--