Bug ID	111414
Summary	[REGRESSION] [BISECTED] Segmentation fault in si_bind_blend_s= tate after removal of the blend state NULL check
Product	Mesa
Version	git
Hardware	x86-64 (AMD64)
OS	Linux (All)
Status	NEW
Severity	normal
Priority	medium
Component	Drivers/Gallium/radeonsi
Assignee	dri-devel@lists.freedesktop.org
Reporter	edmondo.tommasina@gmail.com
QA Contact	dri-devel@lists.freedesktop.org

Bug ID

111414

Summary

[REGRESSION] [BISECTED] Segmentation fault in si_bind_blend_s= tate after removal of the blend state NULL check

Product

Mesa

Version

git

Hardware

x86-64 (AMD64)

Linux (All)

Status

NEW

Severity

normal

Priority

medium

Component

Drivers/Gallium/radeonsi

Assignee

dri-devel@lists.freedesktop.org

Reporter

edmondo.tommasina@gmail.com

QA Contact

dri-devel@lists.freedesktop.org

Created attachment 145084 [deta=
ils]
Backtrace

vlc using vdpau received signal SIGSEGV after the removal of the blend state
NULL check.

Bisected to:

https://gitlab.freedesktop.org/mesa/mesa/commit/b=
758eed9c373db14a5acc04d9522ec9d74e51f1b

commit b758eed9c373db14a5acc04d9522ec9d74e51f1b (HEAD, refs/bisect/bad)
Author: Marek Ol=C5=A1=C3=A1k <marek.olsak@amd.com>
Date:   Tue Jul 30 17:43:41 2019 -0400

    radeonsi: make sure that blend state !=3D NULL and remove all NULL chec=
king

    Reviewed-by: Pierre-Eric Pelloux-Prayer
<pierre-eric.p=
elloux-prayer@amd.com>




The backtrace shows old_blend =3D 0x0 where the new code doesn't check old_=
blend
anymore:
+       if (old_blend->cb_target_mask !=3D blend->cb_target_mask ||


Full backtrace attached, here an extract:

0x00007fff60e6497b in si_bind_blend_state (ctx=3D0x7fff58468f20, state=3D&l=
t;optimized
out>) at ../mesa-9999/src/gallium/drivers/radeonsi/si_state.c:686
686     ../mesa-9999/src/gallium/drivers/radeonsi/si_state.c: No such file =
or
directory.
(gdb) bt full
#0  0x00007fff60e6497b in si_bind_blend_state (ctx=3D0x7fff58468f20,
state=3D<optimized out>) at
../mesa-9999/src/gallium/drivers/radeonsi/si_state.c:686
        sctx =3D 0x7fff58468f20
        old_blend =3D 0x0
        blend =3D 0x7fff584f2220
#1  0x00007fff60cea216 in draw_layers (dirty=3D0x7fff584099b8, s=3D0x7fff58=
4fbf60,
c=3D0x7fff58409788) at
../mesa-9999/src/gallium/auxiliary/vl/vl_compositor_gfx.c:662
        layer =3D 0x7fff584fbf98
        samplers =3D 0x7fff584fbfe8
        num_sampler_views =3D 1
        blend =3D <optimized out>
        vb_index =3D 0
        i =3D 0
        vb_index =3D <optimized out>
        i =3D <optimized out>
        layer =3D <optimized out>
        samplers =3D <optimized out>
        num_sampler_views =3D <optimized out>
        blend =3D <optimized out>
        drawn =3D <optimized out>
#2  vl_compositor_gfx_render (s=3Ds@entry=3D0x7fff584fbf60,
c=3Dc@entry=3D0x7fff58409788, dst_surface=3Ddst_surface@entry=3D0x7=
fff58530980,
dirty_area=3D0x7fff584099b8, dirty_area@entry=3D0x1, clear_dirty=3D<=
optimized out>)
    at ../mesa-9999/src/gallium/auxiliary/vl/vl_compositor_gfx.c:725
No locals.
#3  0x00007fff60ce462c in vl_compositor_render (clear_dirty=3Dtrue,
dirty_area=3D0x1, dst_surface=3D0x7fff58530980, c=3D0x7fff58409788, s=3D0x7=
fff584fbf60)
at ../mesa-9999/src/gallium/auxiliary/vl/vl_compositor.c:755
No locals.
#4  vl_compositor_render (s=3Ds@entry=3D0x7fff584fbf60, c=3Dc@entry=
=3D0x7fff58409788,
dst_surface=3Ddst_surface@entry=3D0x7fff5866b060,
dirty_area=3Ddirty_area@entry=3D0x7fff584099b8, clear_dirty=3Dclear_dir=
ty@entry=3Dtrue)
    at ../mesa-9999/src/gallium/auxiliary/vl/vl_compositor.c:744
No locals.
#5  0x00007fff60cda6ae in vlVdpPresentationQueueDisplay
(presentation_queue=3D<optimized out>, surface=3D4, clip_width=3D<=
optimized out>,
clip_height=3D0, earliest_presentation_time=3D36232721127000)
    at ../mesa-9999/src/gallium/state_trackers/vdpau/presentation.c:262
        dump_window =3D -1
        pq =3D 0x7fff584fbf50
        surf =3D 0x7fff585043d0
        pipe =3D 0x7fff58468f20
        tex =3D 0x7fff58530980
        surf_templ =3D {reference =3D {count =3D 0}, format =3D
PIPE_FORMAT_B8G8R8X8_UNORM, writable =3D 0, texture =3D 0x0, context =3D 0x=
0, width =3D
0, height =3D 0, nr_samples =3D 0, u =3D {tex =3D {level =3D 0, first_layer=
 =3D 0,
last_layer =3D 0}, buf =3D {
              first_element =3D 0, last_element =3D 0}}}
        surf_draw =3D 0x7fff5866b060
        src_rect =3D {x0 =3D 0, x1 =3D 1658, y0 =3D 0, y1 =3D 933}
        dst_clip =3D {x0 =3D 0, x1 =3D 1658, y0 =3D 0, y1 =3D 933}
        dirty_area =3D 0x7fff584099b8
        compositor =3D 0x7fff58409788
        cstate =3D 0x7fff584fbf60
        vscreen =3D 0x7fff58409900