From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1115] i40e: RSS hash conf update fails when hash proto mask in rx_adv_conf is 0
Date: Wed, 26 Oct 2022 14:35:55 +0000 [thread overview]
Message-ID: <bug-1115-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=1115
Bug ID: 1115
Summary: i40e: RSS hash conf update fails when hash proto mask
in rx_adv_conf is 0
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: ivan.malov@oktetlabs.ru
Target Milestone: ---
Opensource ethdev tests [1] have been improved over the past weeks.
With the latest update, test "usecases/update_rss_hash_conf" finds
yet another bug in i40e PMD. If the user has not passed a non-zero
hash protocol mask via "rx_adv_conf" during device configure stage,
any attempts to use rte_eth_dev_rss_hash_update() at a later stage
will fail regardless of hash protocol mask and key being requested.
When the test sees that, it tries to re-configure the ethdev, this
time with the "rx_adv_conf" hash protocol mask being non-zero. The
following invocations of rte_eth_dev_rss_hash_update() do not fail.
In this particular case, the "non-zero" mask being used is in fact
taken from the "flow_type_rss_offloads" field specified by the PMD.
Further research indicates that the PMD considers RSS unconfigured
in the case of zero "rx_adv_conf" hash protocol mask, which is not
correct. Whether the user wants to enable RSS or not is determined
solely by testing RTE_ETH_MQ_RX_RSS_FLAG in "rxmode.mq_mode" field.
If this flag is set, rte_eth_dev_rss_hash_update() should not fail
unless the application tries a wittingly unsupported configuration.
A complete log example can be found at [2].
[1] http://mails.dpdk.org/archives/dev/2022-October/251663.html
[2] https://ts-factory.io/bublik/v2/log/163204?focusId=163697&mode=treeAndlog
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2022-10-26 14:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1115-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.