All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla at busybox.net <bugzilla@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 11411] check-uniq-files issue
Date: Sat, 20 Oct 2018 16:33:33 +0000	[thread overview]
Message-ID: <bug-11411-163-EHaCcty4Qa@https.bugs.busybox.net/> (raw)
In-Reply-To: <bug-11411-163@https.bugs.busybox.net/>

https://bugs.busybox.net/show_bug.cgi?id=11411

--- Comment #2 from Jean-pierre Cartal <jpcartal@free.fr> ---
Here is the patch that I tested on my builds:

diff --git a/package/Makefile.in b/package/Makefile.in
index 58af2ef242..7d3d7c9028 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -216,7 +216,7 @@ TARGET_OBJDUMP  = $(TARGET_CROSS)objdump
 ifeq ($(BR2_STRIP_strip),y)
 STRIP_STRIP_DEBUG := --strip-debug
 TARGET_STRIP = $(TARGET_CROSS)strip
-STRIPCMD = $(TARGET_CROSS)strip --remove-section=.comment
--remove-section=.note
+STRIPCMD = $(TARGET_CROSS)strip --remove-section=.comment
--remove-section=.note -p
 else
 TARGET_STRIP = /bin/true
 STRIPCMD = $(TARGET_STRIP)


BTW, there are also a lot of false positive in staging because of this command
:
$(Q)find $(STAGING_DIR)/usr/lib* -name "*.la" | xargs --no-run-if-empty \
                $(SED) "s:$(BASE_DIR):@BASE_DIR@:g" \
                        -e "s:$(STAGING_DIR):@STAGING_DIR@:g" \
                        $(if $(TOOLCHAIN_EXTERNAL_INSTALL_DIR),\
                                -e
"s:$(TOOLCHAIN_EXTERNAL_INSTALL_DIR):@TOOLCHAIN_EXTERNAL_INSTALL_DIR@:g") \
                        -e "s:\(['= ]\)/usr:\\1 at STAGING_DIR@/usr:g" \
                        $(if $(TOOLCHAIN_EXTERNAL_INSTALL_DIR),\
                                -e
"s:@TOOLCHAIN_EXTERNAL_INSTALL_DIR@:$(TOOLCHAIN_EXTERNAL_INSTALL_DIR):g") \
                        -e "s:@STAGING_DIR@:$(STAGING_DIR):g" \
                        -e "s:@BASE_DIR@:$(BASE_DIR):g"

Do you think a patch using stat/touch to keep the original modification time of
impacted files be interesting ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2018-10-20 16:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19 15:37 [Buildroot] [Bug 11411] New: check-uniq-files issue bugzilla at busybox.net
2018-10-20 12:17 ` [Buildroot] [Bug 11411] " bugzilla at busybox.net
2018-10-20 16:33 ` bugzilla at busybox.net [this message]
2018-10-20 18:46 ` bugzilla at busybox.net
2018-10-20 18:59 ` bugzilla at busybox.net
2018-10-20 22:16 ` bugzilla at busybox.net
2018-10-22  7:20 ` [Buildroot] [Bug 11411] check-uniq-files target issue bugzilla at busybox.net
2018-10-22  7:37 ` bugzilla at busybox.net
2019-02-15 22:06 ` bugzilla at busybox.net
2019-10-09 15:51 ` bugzilla at busybox.net
2019-10-31 22:07 ` bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-11411-163-EHaCcty4Qa@https.bugs.busybox.net/ \
    --to=bugzilla@busybox.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.