All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla at busybox.net <bugzilla@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 12301] New: systemd-journal-gatewayd: config options broken
Date: Wed, 30 Oct 2019 13:02:49 +0000	[thread overview]
Message-ID: <bug-12301-163@https.bugs.busybox.net/> (raw)

https://bugs.busybox.net/show_bug.cgi?id=12301

            Bug ID: 12301
           Summary: systemd-journal-gatewayd: config options broken
           Product: buildroot
           Version: 2019.08
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
          Assignee: unassigned at buildroot.uclibc.org
          Reporter: posted at heine.so
                CC: buildroot at uclibc.org
  Target Milestone: ---

Hi,

I updated my systemd system build to BR 2019.08 and noticed that
systemd-journal-gatewayd was missing in the resulting image.


Commit 2dbce34b3a2c8fc1a854395f6c33df658371eae4 added a config option
BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE to enable the systemd-journal-remote
service.

If it is selected the -Dremote=true flag gets explicitly set. If not it is
explicitly set to false.

But as defined in the systemd config (see [0]) -Dremote=true is used to enable
systemd-journal-remote as well as systemd-journal-gatewayd. There is no switch
to only build one of them.

Further the default value of the -Dremote flag is true (see [1]).

So previous to this commit both binaries are already built and installed when
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY is set. I verfied this in my built
2019.05.1 image. Both binaries are there.


As with this commit, when BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY=Y and
BR2_PACKAGE_SYSTEMD_JOURNAL_REMOTE=N is set -Dremote=false is explicitly set
and systemd builds neither of the binaries.



So I would suggest to revert this commit as it breaks configs and adds no
functionality. 
Also I would suggest to extend the description of
BR2_PACKAGE_SYSTEMD_JOURNAL_GATEWAY to include a mention of
"systemd-journal-remote".


Regards,
Michael

[0] https://github.com/systemd/systemd/blob/master/meson.build#L2207
[1] https://github.com/systemd/systemd/blob/master/meson.build#L1253

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2019-10-30 13:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 13:02 bugzilla at busybox.net [this message]
2019-10-30 21:07 ` [Buildroot] [Bug 12301] New: systemd-journal-gatewayd: config options broken Arnout Vandecappelle
2019-11-18 16:54   ` Jérémy ROSEN
2019-11-27 20:47 ` [Buildroot] [Bug 12301] " bugzilla at busybox.net
2020-10-23 10:35 ` bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-12301-163@https.bugs.busybox.net/ \
    --to=bugzilla@busybox.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.