All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla at busybox.net <bugzilla@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 13836] package build failure when target install set to no on pkg-generic pkg types
Date: Sun, 13 Jun 2021 13:25:33 +0000	[thread overview]
Message-ID: <bug-13836-163-54SI0f84hV@https.bugs.busybox.net/> (raw)
In-Reply-To: <bug-13836-163@https.bugs.busybox.net/>

https://bugs.busybox.net/show_bug.cgi?id=13836

--- Comment #2 from Yann E. MORIN <yann.morin.1998@free.fr> ---
Matt, All,

I was thinking a proper solution to the issue would be something
along the lines of:

```diff
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 9fbc63d19e..5e53d008e1 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -1120,6 +1120,12 @@ endif # ifneq ($$(call qstrip,$$($(2)_SOURCE)),)
 # configuration
 ifeq ($$($$($(2)_KCONFIG_VAR)),y)

+ifeq ($$($(2)_TYPE),target)
+ifeq ($$(filter YES,$$($(2)_INSTALL_STAGING) $$($(2)_INSTALL_IMAGES)
$$($(2)_INSTALL_TARGET)),)
+$$(error $(1) does not install anything anywhere)
+endif
+endif
+
 # Ensure the calling package is the declared provider for all the virtual
 # packages it claims to be an implementation of.
 ifneq ($$($(2)_PROVIDES),)
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-06-13 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 14:57 [Buildroot] [Bug 13836] New: package build failure when target install set to no on pkg-generic pkg types bugzilla at busybox.net
2021-06-13 13:16 ` [Buildroot] [Bug 13836] " bugzilla at busybox.net
2021-06-13 13:25 ` bugzilla at busybox.net [this message]
2021-06-13 14:34 ` bugzilla at busybox.net
2021-06-16 20:14 ` bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-13836-163-54SI0f84hV@https.bugs.busybox.net/ \
    --to=bugzilla@busybox.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.