All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/core Bug 1472] mbuf: some dynamic fields are mishandled if IOVA as PA is disabled during build
Date: Sat, 22 Jun 2024 16:08:03 +0000	[thread overview]
Message-ID: <bug-1472-3@http.bugs.dpdk.org/> (raw)

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1472

            Bug ID: 1472
           Summary: mbuf: some dynamic fields are mishandled if IOVA as PA
                    is disabled during build
           Product: DPDK
           Version: 22.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: mb@smartsharesystems.com
  Target Milestone: ---

If IOVA as PA is disabled during build (i.e. !RTE_IOVA_AS_PA), a second dynamic
field [1] becomes available in the rte_mbuf structure. This is fine.

rte_mbuf_dynfield_copy() [2] does not copy this field, although it should.

In turn, this also affects __rte_pktmbuf_copy_hdr(), which in turn affects
rte_pktmbuf_attach() and rte_pktmbuf_copy().

The bug was introduced by the patch [3] making the dynfield2 available for
dynamic fields.

The bug is present in DPDK 22.11(incl. 22.11.5) - 24.07-rc1.
The bug is not present in DPDK 22.07.

[1]:
https://elixir.bootlin.com/dpdk/v22.11.5/source/lib/mbuf/rte_mbuf_core.h#L609
[2]: https://elixir.bootlin.com/dpdk/v22.11.5/source/lib/mbuf/rte_mbuf.h#L1121
[3]:
https://git.dpdk.org/dpdk/commit/lib/mbuf/rte_mbuf_dyn.c?id=03b57eb7ab9a1203ed6eee67ec0d8ffbc44ca750

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 3603 bytes --]

             reply	other threads:[~2024-06-22 16:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-22 16:08 bugzilla [this message]
2024-07-04  3:54 ` [DPDK/core Bug 1472] mbuf: some dynamic fields are mishandled if IOVA as PA is disabled during build bugzilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1472-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.