From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@bugzilla.kernel.org
Subject: [Bug 16375] New: missing blit_vb check in r600_prepare_blit_copy
Date: Mon, 12 Jul 2010 20:56:51 GMT
Message-ID:
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.sourceforge.net
To: dri-devel@lists.sourceforge.net
List-Id: dri-devel@lists.freedesktop.org
https://bugzilla.kernel.org/show_bug.cgi?id=16375
Summary: missing blit_vb check in r600_prepare_blit_copy
Product: Drivers
Version: 2.5
Kernel Version: 2.6.35-rc4
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Video(DRI - non Intel)
AssignedTo: drivers_video-dri@kernel-bugs.osdl.org
ReportedBy: git.user@gmail.com
Regression: No
r600_prepare_blit_copy issing check of dev_priv->blit_vb to be filled by
r600_nomm_get_vb. r600_nomm_get_vb can fail and return EAGAIN and we'll see a
NULL pointer dereference.
fix:
--- git/linux-2.6/drivers/gpu/drm/radeon/r600_blit.c 2010-03-09
23:26:42.601820012 +0300
+++ linux-2.6.35-rc4/drivers/gpu/drm/radeon/r600_blit.c 2010-07-12
23:55:43.246560111 +0400
@@ -541,6 +541,8 @@ r600_prepare_blit_copy(struct drm_device
DRM_DEBUG("\n");
r600_nomm_get_vb(dev);
+ if (!dev_priv->blit_vb)
+ return;
dev_priv->blit_vb->file_priv = file_priv;
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
--