From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/ethdev Bug 1740] net/bnxt: duplicate code in branches
Date: Thu, 03 Jul 2025 16:55:43 +0000 [thread overview]
Message-ID: <bug-1740-3@https.bugs.dpdk.org/> (raw)
[-- Attachment #1: Type: text/plain, Size: 3770 bytes --]
https://bugs.dpdk.org/show_bug.cgi?id=1740
Bug ID: 1740
Summary: net/bnxt: duplicate code in branches
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: minor
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: stephen@networkplumber.org
Target Milestone: ---
Building with compiler warning about duplicate branches finds:
[834/3631] Compiling C object
drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_flow.c.o
../drivers/net/bnxt/bnxt_flow.c: In function
‘bnxt_validate_and_parse_flow_type’:
../drivers/net/bnxt/bnxt_flow.c:263:80: warning: this condition has identical
branches [-Wduplicated-branches]
263 |
NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
|
^
../drivers/net/bnxt/bnxt_flow.c:383:79: warning: this condition has identical
branches [-Wduplicated-branches]
383 |
HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_IP_ADDR_TYPE_IPV4 :
|
^
../drivers/net/bnxt/bnxt_flow.c:448:75: warning: this condition has identical
branches [-Wduplicated-branches]
448 |
NTUPLE_FLTR_ALLOC_INPUT_IP_ADDR_TYPE_IPV6 :
|
^
[835/3631] Compiling C object
drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_stats.c.o
[836/3631] Compiling C object
drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_rxq.c.o
[837/3631] Compiling C object
drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_txq.c.o
[838/3631] Compiling C object
drivers/libtmp_rte_net_bnx2x.a.p/net_bnx2x_bnx2x_stats.c.o
[839/3631] Compiling C object
drivers/libtmp_rte_net_bnx2x.a.p/net_bnx2x_ecore_sp.c.o
[840/3631] Compiling C object
drivers/libtmp_rte_common_qat.a.p/crypto_qat_qat_asym.c.o
[841/3631] Compiling C object
drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_txr.c.o
../drivers/net/bnxt/bnxt_txr.c: In function ‘bnxt_start_xmit’:
../drivers/net/bnxt/bnxt_txr.c:410:74: warning: duplicated ‘if’ condition
[-Wduplicated-cond]
410 | } else if ((tx_pkt->ol_flags &
PKT_TX_OIP_IIP_UDP_CKSUM) ==
../drivers/net/bnxt/bnxt_txr.c:402:78: note: previously used here
402 | } else if ((tx_pkt->ol_flags &
PKT_TX_OIP_IIP_TCP_UDP_CKSUM) ==
../drivers/net/bnxt/bnxt_txr.c:418:70: warning: duplicated ‘if’ condition
[-Wduplicated-cond]
418 | } else if ((tx_pkt->ol_flags & PKT_TX_IIP_UDP_CKSUM) ==
../drivers/net/bnxt/bnxt_txr.c:414:74: note: previously used here
414 | } else if ((tx_pkt->ol_flags &
PKT_TX_IIP_TCP_UDP_CKSUM) ==
../drivers/net/bnxt/bnxt_txr.c:430:70: warning: duplicated ‘if’ condition
[-Wduplicated-cond]
430 | } else if ((tx_pkt->ol_flags & PKT_TX_OIP_UDP_CKSUM) ==
../drivers/net/bnxt/bnxt_txr.c:426:74: note: previously used here
426 | } else if ((tx_pkt->ol_flags &
PKT_TX_OIP_TCP_UDP_CKSUM) ==
../drivers/net/bnxt/bnxt_txr.c:450:73: warning: duplicated ‘if’ condition
[-Wduplicated-cond]
450 | } else if ((tx_pkt->ol_flags & RTE_MBUF_F_TX_UDP_CKSUM)
==
../drivers/net/bnxt/bnxt_txr.c:442:70: note: previously used here
442 | } else if ((tx_pkt->ol_flags & PKT_TX_TCP_UDP_CKSUM) ==
[842/3631] Compiling C object
drivers/libtmp_rte_net_bnxt.a.p/net_bnxt_bnxt_reps.c.o
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #2: Type: text/html, Size: 5690 bytes --]
reply other threads:[~2025-07-03 16:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1740-3@https.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.