From: bugzilla-daemon@bugzilla.kernel.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 178421] [regression] Radeon Oops on shutdown
Date: Sun, 30 Oct 2016 11:01:58 +0000 [thread overview]
Message-ID: <bug-178421-2300-1ae29dM6dA@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-178421-2300@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=178421
Jouni Mettälä <jtmettala@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Regression|No |Yes
--- Comment #6 from Jouni Mettälä <jtmettala@gmail.com> ---
With patches referenced in comment 1, bisect pointed to
6b25e21fa6f26d0f0d45f161d169029411c84286
Merge tag 'drm-for-v4.9' of git://people.freedesktop.org/~airlied/linux
I was still bit unsure but after removing these shutdown seems to work.
@@ -362,6 +361,17 @@ radeon_pci_remove(struct pci_dev *pdev)
drm_put_dev(dev);
}
+static void
+radeon_pci_shutdown(struct pci_dev *pdev)
+{
+ /* if we are running in a VM, make sure the device
+ * torn down properly on reboot/shutdown.
+ * unfortunately we can't detect certain
+ * hypervisors so just do this all the time.
+ */
+ radeon_pci_remove(pdev);
+}
+
static int radeon_pmops_suspend(struct device *dev)
{
struct pci_dev *pdev = to_pci_dev(dev);
@@ -574,6 +588,7 @@ static struct pci_driver radeon_kms_pci_driver = {
.id_table = pciidlist,
.probe = radeon_pci_probe,
.remove = radeon_pci_remove,
+ .shutdown = radeon_pci_shutdown,
.driver.pm = &radeon_pm_ops,
};
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/diff/drivers/gpu/drm/radeon/radeon_drv.c?id=6b25e21fa6f26d0f0d45f161d169029411c84286
During bisect some kernels failed to boot with initrd and UUID. Without initrd
they booted but still didn't shutdown.
--
You are receiving this mail because:
You are watching the assignee of the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-10-30 11:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 16:30 [Bug 178421] New: [regression] Radeon Oops on shutdown bugzilla-daemon
2016-10-19 16:34 ` [Bug 178421] " bugzilla-daemon
2016-10-21 0:38 ` bugzilla-daemon
2016-10-24 13:20 ` bugzilla-daemon
2016-10-24 13:27 ` bugzilla-daemon
2016-10-25 3:15 ` bugzilla-daemon
2016-10-30 11:01 ` bugzilla-daemon [this message]
2016-10-30 16:11 ` bugzilla-daemon
2016-10-30 23:49 ` bugzilla-daemon
2016-10-31 16:27 ` bugzilla-daemon
2016-10-31 21:52 ` bugzilla-daemon
2016-11-17 15:34 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-178421-2300-1ae29dM6dA@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.