All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@kernel.org
To: linux-scsi@vger.kernel.org
Subject: [Bug 199887] Fibre login failure on older adapters
Date: Sat, 17 Sep 2022 20:50:46 +0000	[thread overview]
Message-ID: <bug-199887-11613-vymC70BFaN@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-199887-11613@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=199887

--- Comment #5 from Pavel Kankovsky (peak@argo.troja.mff.cuni.cz) ---
Some additional findings:

1. It turns out qla2x00_get_node_name_list() was introduced in 3.5 and it was
called from qla_target.c until 3.11 when the call was removed and the function
remained unused until its own removal in 4.11.

I have not tested whether it would work on an old HBA but it is far from
certain (its result was an array of "struct qla_port_24xx_data", corresponding
to "struct get_name_list" in recent versions), and even if it would, it would
not help much (there seem to be two variants of MBC_PORT_NODE_NAME_LIST, the
old function invoked the variant providing less data while the current code
needs the variant providing more data, "struct get_name_list_extended").

2. The driver is sometimes unable to relogin when an old HBA reconnects to the
fabric because "Async-login" keeps failing with 4007 ie. MBS_PORT_ID_USED. It
turns out qla24xx_handle_plogi_done_event expects an offending loopid in
ea->iop[1] but qla2x00_mbx_iocb_entry stores the value in ea->data[1].

(A similar problem occurs during the handling 4008 ie. MBS_LOOP_ID_USED when
qla24xx_handle_plogi_done_event expects an offending portid in ea->iop[1] but
it is not stored anywhere. But the driver seems to be able to recover in this
case.)

3. Newer HBAs seem to use the same command (MBC_LOGIN_FABRIC_PORT) for both
fabric and private loop port login but old HBAs need a different command
(MBC_LOGIN_LOOP_PORT) in the latter case. See qla2x00_local_device_login.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

      parent reply	other threads:[~2022-09-17 20:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-199887-11613@https.bugzilla.kernel.org/>
2021-12-29  3:43 ` [Bug 199887] Fibre login failure on older adapters bugzilla-daemon
2022-08-28 19:54 ` bugzilla-daemon
2022-09-17 20:50 ` bugzilla-daemon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-199887-11613-vymC70BFaN@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.