From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 20] Undefined behavior caused by NUMA function in eal_memory
Date: Sun, 01 Apr 2018 12:30:07 +0000 [thread overview]
Message-ID: <bug-20-3@http.dpdk.org/tracker/> (raw)
https://dpdk.org/tracker/show_bug.cgi?id=20
Bug ID: 20
Summary: Undefined behavior caused by NUMA function in
eal_memory
Product: DPDK
Version: unspecified
Hardware: All
OS: Linux
Status: CONFIRMED
Severity: normal
Priority: Normal
Component: core
Assignee: dev@dpdk.org
Reporter: solal.pirelli@gmail.com
Target Milestone: ---
In linuxapp's eal_memory.c, the map_all_hugepages function begins by declaring
and initializing variables, including a nodemask
(http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal_memory.c?h=v18.02#n344).
However, this initialization occurs before the numa_available function is
called. According to the libnuma documentation
(https://linux.die.net/man/3/numa), all other functions have undefined behavior
if numa_available returns -1.
The initialization of the nodemask needs to be moved after the numa_available
call, and consequently its freeing at the end of the function needs to be
conditional on it not being NULL.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2018-04-01 12:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-20-3@http.dpdk.org/tracker/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.