All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-f2fs-devel@lists.sourceforge.net
Subject: [Bug 200951] kernel NULL pointer dereference in update_sit_entry
Date: Mon, 03 Sep 2018 01:27:12 +0000	[thread overview]
Message-ID: <bug-200951-202145-lBDwBkpU1U@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-200951-202145@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=200951

--- Comment #11 from Chao Yu (chao@kernel.org) ---
Actually, the problem here is during mount(),  both blk_queue_discard(q) and
f2fs_sb_has_blkzoned(sbi) return false, so f2fs will skip allocating memory for
se->discard_map.

static inline bool f2fs_discard_en(struct f2fs_sb_info *sbi)
{
        struct request_queue *q = bdev_get_queue(sbi->sb->s_bdev);

        return blk_queue_discard(q) || f2fs_sb_has_blkzoned(sbi);
}

[    4.372580] f2fs_discard_en(1):0
[    4.498957] f2fs_discard_en(2):0

But later, during update_sit_entiry(), f2fs_discard_en() return true, then it
will cause f2fs to update se->discard_map bitmap, result in panic.

[   56.939547] f2fs_discard_en(3):1 new_blkaddr:0xFFFF00000AB0383C
[   56.945027] f2fs_discard_en(5):1 se:0xFFFF8000ED285ED8


Is there any interface we can turn on discard of device in real time?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

  parent reply	other threads:[~2018-09-03  1:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 13:44 [Bug 200951] New: kernel NULL pointer dereference in update_sit_entry bugzilla-daemon
2018-08-27 13:45 ` [Bug 200951] " bugzilla-daemon
2018-08-27 13:46 ` bugzilla-daemon
2018-08-31  8:17 ` bugzilla-daemon
2018-09-01 12:53 ` bugzilla-daemon
2018-09-01 12:54 ` bugzilla-daemon
2018-09-01 13:18 ` bugzilla-daemon
2018-09-02  6:52 ` bugzilla-daemon
2018-09-02 16:47 ` bugzilla-daemon
2018-09-02 16:49 ` bugzilla-daemon
2018-09-02 16:50 ` bugzilla-daemon
2018-09-03  1:27 ` bugzilla-daemon [this message]
2018-09-03  9:35 ` bugzilla-daemon
2018-09-03  9:41 ` bugzilla-daemon
2018-09-03  9:54 ` bugzilla-daemon
2018-09-04  9:43 ` bugzilla-daemon
2018-09-04 12:51 ` bugzilla-daemon
2018-09-04 14:13 ` bugzilla-daemon
2018-09-11  3:15 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-200951-202145-lBDwBkpU1U@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.