All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linuxppc-dev@lists.ozlabs.org
Subject: [Bug 205327] kmemleak reports various leaks in "swapper/0"
Date: Tue, 29 Oct 2019 11:27:47 +0000	[thread overview]
Message-ID: <bug-205327-206035-8QehXlOXV3@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-205327-206035@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=205327

Michael Ellerman (michael@ellerman.id.au) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |michael@ellerman.id.au

--- Comment #3 from Michael Ellerman (michael@ellerman.id.au) ---
That looks like a pretty straight forward memory leak here:

static void attach_node_and_children(struct device_node *np)
{
        struct device_node *next, *dup, *child;
        unsigned long flags;
        const char *full_name;

        full_name = kasprintf(GFP_KERNEL, "%pOF", np);

        if (!strcmp(full_name, "/__local_fixups__") ||
            !strcmp(full_name, "/__fixups__"))

>> missing kfree(full_name);

                return;

        dup = of_find_node_by_path(full_name);
        kfree(full_name);
        if (dup) {
                update_node_properties(np, dup);
                return;
        }


Do you want to send a patch?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2019-10-29 11:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26 19:30 [Bug 205327] New: kmemleak reports various leaks in "swapper/0" bugzilla-daemon
2019-10-26 19:31 ` [Bug 205327] " bugzilla-daemon
2019-10-26 19:50 ` bugzilla-daemon
2019-10-29 11:27 ` bugzilla-daemon [this message]
2019-10-31  1:22 ` bugzilla-daemon
2019-11-18 19:17 ` bugzilla-daemon
2019-11-19  1:26 ` bugzilla-daemon
2020-01-05 12:46 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-205327-206035-8QehXlOXV3@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.