From: bugzilla-daemon@bugzilla.kernel.org
To: linux-ext4@vger.kernel.org
Subject: [Bug 205569] potential data race (likely benign) on inode->i_state (reading and writing to different bits)
Date: Tue, 19 Nov 2019 00:58:46 +0000 [thread overview]
Message-ID: <bug-205569-13602-FiMdbbgAXf@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-205569-13602@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=205569
Theodore Tso (tytso@mit.edu) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tytso@mit.edu
--- Comment #1 from Theodore Tso (tytso@mit.edu) ---
The writeback thread is only applicable for data files. While rmdir() is only
applicable for directories. Also, in both of these function traces, what you
referenced is i_state bits being *read*:
[WRITE] dirty = inode->i_state & I_DIRTY;
^^^^^ not correct!
That being said, there are places in fs/fs-writeback.c where i_state is
modified, and there are code paths where ext4_orphan_add() can be called on
regular data files --- just not the ones you've listed in this bug.
Can you recheck the call traces and make sure they are correct?
--
You are receiving this mail because:
You are watching the assignee of the bug.
next prev parent reply other threads:[~2019-11-19 0:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 20:41 [Bug 205569] New: potential data race (likely benign) on inode->i_state (reading and writing to different bits) bugzilla-daemon
2019-11-19 0:58 ` bugzilla-daemon [this message]
2019-11-19 1:02 ` [Bug 205569] " bugzilla-daemon
2019-11-19 1:26 ` bugzilla-daemon
2019-11-19 1:27 ` bugzilla-daemon
2019-11-19 1:33 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-205569-13602-FiMdbbgAXf@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.