All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-xfs@vger.kernel.org
Subject: [Bug 206429] New: xfs_admin can't print both label and UUID for mounted filesystems
Date: Wed, 05 Feb 2020 12:28:07 +0000	[thread overview]
Message-ID: <bug-206429-201763@https.bugzilla.kernel.org/> (raw)

https://bugzilla.kernel.org/show_bug.cgi?id=206429

            Bug ID: 206429
           Summary: xfs_admin can't print both label and UUID for mounted
                    filesystems
           Product: File System
           Version: 2.5
    Kernel Version: n/a
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: XFS
          Assignee: filesystem_xfs@kernel-bugs.kernel.org
          Reporter: vtrefny@redhat.com
        Regression: No

Created attachment 287143
  --> https://bugzilla.kernel.org/attachment.cgi?id=287143&action=edit
patch for xfs_admin

Using "xfs_admin -lu" to print both label and UUID of a mounted XFS filesystem
stopped working in xfs_admin version 5.4.0.
Label is correctly printed, but the UUID is missing:

$ sudo xfs_admin -lu /dev/sda
label = "aaa"

Printing only UUID works as expected:

$ sudo xfs_admin -u /dev/sda
UUID = a3367b49-6f3f-4f50-9b34-38b1561da085

Command also works as expected for an unmounted filesystem
$ sudo xfs_admin -lu /dev/sda
label = "aaa"
UUID = a3367b49-6f3f-4f50-9b34-38b1561da085

The bug is caused by this change --
https://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git/commit/?id=3f153e051abccce0c120ade5c08a675a50cecee9
-- xfs_io is now used to print label and xfs_admin exists after printing it.
I'm attaching a simple naive patch for xfs_admin that fixes this issue.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

             reply	other threads:[~2020-02-05 12:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 12:28 bugzilla-daemon [this message]
2020-02-05 15:39 ` [Bug 206429] xfs_admin can't print both label and UUID for mounted filesystems bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-206429-201763@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.