From: bugzilla-daemon@bugzilla.kernel.org
To: kvm@vger.kernel.org
Subject: [Bug 208081] Memory leak in kvm_async_pf_task_wake
Date: Tue, 09 Jun 2020 13:00:36 +0000 [thread overview]
Message-ID: <bug-208081-28872-77yKXsjHqa@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-208081-28872@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=208081
--- Comment #4 from Paolo Bonzini (bonzini@gnu.org) ---
That patch won't work, most APFs have a node that comes from the stack. The
issue must be arising when you enter this branch of kvm_async_pf_task_wake:
/*
* async PF was not yet handled.
* Add dummy entry for the token.
*/
n = kzalloc(sizeof(*n), GFP_ATOMIC);
but it should be handled here in kvm_async_pf_task_wait:
if (e) {
/* dummy entry exist -> wake up was delivered ahead of PF */
hlist_del(&e->link);
raw_spin_unlock(&b->lock);
kfree(e);
return false;
}
--
You are receiving this mail because:
You are watching the assignee of the bug.
next prev parent reply other threads:[~2020-06-09 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 0:35 [Bug 208081] New: Memory leak in kvm_async_pf_task_wake bugzilla-daemon
2020-06-06 0:37 ` [Bug 208081] " bugzilla-daemon
2020-06-08 0:46 ` bugzilla-daemon
2020-06-09 7:17 ` bugzilla-daemon
2020-06-09 13:00 ` bugzilla-daemon [this message]
2020-06-09 17:09 ` bugzilla-daemon
2020-06-11 1:03 ` bugzilla-daemon
2023-01-24 7:54 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-208081-28872-77yKXsjHqa@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.