[Bug 209011] asus-wmi always reports tablet mode on a ZenBook UX390UAK

[bugzilla-daemon@bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=209011

--- Comment #13 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Thanks, I'm pretty sure I know what is going on here. I'm writing a kernel
patch to fix this now.

If you are curious what is going on here is a comment which I just wrote to
document the code/fix I'm working on:

/*
 * Helper code to detect 360 degree hinges (yoga) style 2-in-1 devices using 2
accelerometers
 * to allow the OS to determine the angle between the display and the base of
the device.
 *
 * On Windows these are read by a special HingeAngleService process which calls
undocumented
 * ACPI methods, to let the firmware know if the 2-in-1 is in tablet- or
laptop-mode.
 * The firmware may use this to disable the kbd and touchpad to avoid spurious
input in
 * tablet-mode as well as to report SW_TABLET_MODE info to the OS.
 *
 * Since Linux does not call these undocumented methods, the SW_TABLET_MODE
info reported
 * by the intel-hid / intel-vbtn drivers is incorrect. These drivers use the
detection
 * code in this file to disable SW_TABLET_MODE reporting to avoid reporting
broken info
 * (instead userspace can derive the status itself by directly reading the 2
accels).
 */

Now I just need to actually write the mentioned detection code, test it on one
of my own devices and then hook it up in the intel-vbtn.c and intel-hid
drivers.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.