All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: platform-driver-x86@vger.kernel.org
Subject: [Bug 210269] Tablet mode not correctly reported after wake-up from hibernate
Date: Sat, 21 Nov 2020 14:17:43 +0000	[thread overview]
Message-ID: <bug-210269-215701-luk9PCKbpV@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-210269-215701@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=210269

Hans de Goede (jwrdegoede@fedoraproject.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwrdegoede@fedoraproject.or
                   |                            |g

--- Comment #10 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
(In reply to Benjamin Berg from comment #8)
> I wonder if we should only do this if the switch actually changed. But I
> suspect the input layer will already take care of that case.

There is no need to check if the switch actually changed, as you already
presumed the input layer will filter out the event if there is no change.

(In reply to Julian from comment #9)
> Your patch seems to fix the problem Benjamin, thanks.

Awesome, thank you for testing.

Benjamin, can you submit the fix for this upstream please ? Then I'll pick it
up and merge it for the 5.11 cycle.

Note please add the following tags to the commit msg:

Fixes: dda3ec0aa631 ("platform/x86: thinkpad_acpi: Implement tablet mode using
GMMS method")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210269

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

      parent reply	other threads:[~2020-11-21 14:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 15:39 [Bug 210269] New: Tablet mode not correctly reported after wake-up from hibernate bugzilla-daemon
2020-11-19 16:46 ` [Bug 210269] " bugzilla-daemon
2020-11-19 17:06 ` bugzilla-daemon
2020-11-19 18:09 ` bugzilla-daemon
2020-11-19 18:14 ` bugzilla-daemon
2020-11-19 19:42 ` bugzilla-daemon
2020-11-19 19:59 ` bugzilla-daemon
2020-11-19 20:03 ` bugzilla-daemon
2020-11-19 20:11 ` bugzilla-daemon
2020-11-21 13:40 ` bugzilla-daemon
2020-11-21 14:17 ` bugzilla-daemon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-210269-215701-luk9PCKbpV@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.