From: bugzilla-daemon@bugzilla.kernel.org
To: kvm@vger.kernel.org
Subject: [Bug 210695] error: kvm run failed Invalid argument
Date: Wed, 16 Dec 2020 02:28:25 +0000 [thread overview]
Message-ID: <bug-210695-28872-b4D0Lqj7rJ@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-210695-28872@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=210695
--- Comment #2 from Richard Herbert (rherbert@sympatico.ca) ---
Hi, Sean. I'm no programmer, unfortunately, but when kernel 5.10-rc4 was
released, this was the patch that I suspected had fixed the problem. I don't
find this code is 5.10.1, so it must have been reverted or moved.
diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
index 27e381c9da6c2..ff28a5c6abd63 100644
--- a/arch/x86/kvm/mmu/tdp_mmu.c
+++ b/arch/x86/kvm/mmu/tdp_mmu.c
@@ -49,7 +49,14 @@ bool is_tdp_mmu_root(struct kvm *kvm, hpa_t hpa)
{
struct kvm_mmu_page *sp;
+ if (!kvm->arch.tdp_mmu_enabled)
+ return false;
+ if (WARN_ON(!VALID_PAGE(hpa)))
+ return false;
+
sp = to_shadow_page(hpa);
+ if (WARN_ON(!sp))
+ return false;
return sp->tdp_mmu_page && sp->root_count;
}
--
You are receiving this mail because:
You are watching the assignee of the bug.
next prev parent reply other threads:[~2020-12-16 2:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 0:11 [Bug 210695] New: error: kvm run failed Invalid argument bugzilla-daemon
2020-12-15 0:13 ` [Bug 210695] " bugzilla-daemon
2020-12-16 2:03 ` bugzilla-daemon
2020-12-16 2:28 ` bugzilla-daemon [this message]
2020-12-16 2:57 ` bugzilla-daemon
2020-12-16 20:49 ` bugzilla-daemon
2020-12-16 23:08 ` bugzilla-daemon
2020-12-16 23:14 ` bugzilla-daemon
2020-12-17 19:54 ` bugzilla-daemon
2020-12-18 3:10 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-210695-28872-b4D0Lqj7rJ@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.