From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC21C433C1 for ; Wed, 24 Mar 2021 22:57:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 820D261993 for ; Wed, 24 Mar 2021 22:57:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 820D261993 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bugzilla.kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A2236EABA; Wed, 24 Mar 2021 22:57:27 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id A63F66EABA for ; Wed, 24 Mar 2021 22:57:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPS id 7A03361A0A for ; Wed, 24 Mar 2021 22:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616626645; bh=NpWEBT37qDOuiSCJUpDEL0W8gYSbLuFkvQ1VTsIkjOg=; h=From:To:Subject:Date:In-Reply-To:References:From; b=OwqtyFyMLF5Bb6AeBCoCldh3rwwJsKWZgEh+euCf/zhuqWhGksARqZ/8Z9hYIPTDv gyONEetmCopP+I1SrjoRl08iBusLqx6PJbNfrA28dT9+qQotH9hHOx8PyJwojJKMCT OdHOezD2awLtnWvxFr+b1YRC7fYDwluihnzmEQZQ4Zur36soSJHkfCTS24dbynhcic uXe2CJnjIaCUOh5vGG4lJAT436nACJtqrWqYVqc53Ca8wlBi2ov1BTmiEf9P0c2Ome gansWKYTHpEqbS9Bsxns+Luu1rXuN+e+I1kpDDPA8XNnNB5JWfL64H4Daj1jT1ZESo 4BT6sFdKjNNzA== From: bugzilla-daemon@bugzilla.kernel.org To: dri-devel@lists.freedesktop.org Subject: [Bug 212427] [AMDGPU] Multiple ttm_bo_release warnings Date: Wed, 24 Mar 2021 22:57:25 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo drivers_video-dri@kernel-bugs.osdl.org X-Bugzilla-Product: Drivers X-Bugzilla-Component: Video(DRI - non Intel) X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: rankincj@yahoo.com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: drivers_video-dri@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cf_regression Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" https://bugzilla.kernel.org/show_bug.cgi?id=212427 Chris Rankin (rankincj@yahoo.com) changed: What |Removed |Added ---------------------------------------------------------------------------- Regression|No |Yes --- Comment #1 from Chris Rankin (rankincj@yahoo.com) --- I am assuming that these warnings are all due to this one patch: diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 22073e77fdf9a..a76eb2c14e8c5 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -514,7 +514,7 @@ static void ttm_bo_release(struct kref *kref) * shrinkers, now that they are queued for * destruction. */ - if (bo->pin_count) { + if (WARN_ON(bo->pin_count)) { bo->pin_count = 0; ttm_bo_del_from_lru(bo); ttm_bo_add_mem_to_lru(bo, &bo->mem); which would imply that the only real difference between 5.11.8 and 5.11.9 is "noise". Is this warning highlighting a real problem? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel