All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@kernel.org
To: platform-driver-x86@vger.kernel.org
Subject: [Bug 213297] ideapad-laptop: DYTC interface not found, several functionalities missing
Date: Wed, 22 Jun 2022 08:51:53 +0000	[thread overview]
Message-ID: <bug-213297-215701-Hv63W0JtKg@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-213297-215701@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=213297

Hans de Goede (jwrdegoede@fedoraproject.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwrdegoede@fedoraproject.or
                   |                            |g

--- Comment #8 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
(In reply to Luis O from comment #7)
> I came across this issue, and I checked the ideapad-acpi source code and for
> some reason it now allows DYTC version 4, but only for 1 laptop model. 
> https://github.com/torvalds/linux/blob/
> ca1fdab7fd27eb069df1384b2850dcd0c2bebe8d/drivers/platform/x86/ideapad-laptop.
> c#L871

Right, this is done because we don't know if DYTC version 4 will work on all
models. The ideapad platform-profile code was based on the ThinkPad code
contibuted by Lenovo and that was for version 5.

So for now we only allow using v4 on tested devices.

What would be good is to add a module parameter to allow using the
platform-profile code on v4 devices for easier testing. If you can submit a
patch to do that that would be great.

Or if you're not into writing kernel patches, I can write such a patch and then
you can test it on your model. Note this will require you to build your own
kernel from source.

And if the testing of the patch also shows that your model works correctly,
then your model can also be added to the list of devices on which using v4 DYTC
support is allowed (and eventually if that list becomes quite big we may choose
to enable this by default).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2022-06-22  8:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 13:36 [Bug 213297] New: ideapad-laptop: DYTC interface not found, several functionalities missing bugzilla-daemon
2021-05-31 13:38 ` [Bug 213297] " bugzilla-daemon
2021-05-31 13:38 ` bugzilla-daemon
2021-05-31 14:26 ` bugzilla-daemon
2021-06-01 19:00 ` bugzilla-daemon
2021-06-01 19:23 ` bugzilla-daemon
2021-06-01 19:45 ` bugzilla-daemon
2022-06-21 21:19 ` bugzilla-daemon
2022-06-22  8:51 ` bugzilla-daemon [this message]
2022-06-22  9:46 ` bugzilla-daemon
2022-06-23 12:00 ` bugzilla-daemon
2022-06-23 15:14 ` bugzilla-daemon
2022-06-27 14:23 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-213297-215701-Hv63W0JtKg@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.