[Bug 214967] mvsas not detecting some disks

[bugzilla-daemon@bugzilla.kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=214967

--- Comment #12 from Matthew Perkowski (mgperkow@gmail.com) ---
(In reply to Damien Le Moal from comment #11)
> (In reply to Matthew Perkowski from comment #8)
> > (In reply to Damien Le Moal from comment #6)
> > > (In reply to Bart Van Assche from comment #5)
> > > > On 11/15/21 2:34 PM, bugzilla-daemon@bugzilla.kernel.org wrote:
> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=214967
> > > > > 
> > > > > --- Comment #4 from Matthew Perkowski (mgperkow@gmail.com) ---
> > > > > Bisection has identified commit
> > 2360fa1812cd77e1de13d3cca789fbd23462b651
> > > as
> > > > > the
> > > > > origin of the issue.
> > > 
> > > Hmm... It seems very strange that this patch creates the problem. Even
> with
> > > a bug, the worst that could happen is failing to detect NCQ priority
> > support.
> > > 
> > > The problem is likely related to the errors "ata14.00: Read log page 0x08
> > > failed, Emask 0x1" which come from the kernel trying to access a non
> > > existent log page (IDENTIFY DEVICE data log), which is tried when probing
> > > for NCQ priority support.
> > > 
> > > libata ignores this error, not enabling the feature that was being
> probed.
> > > The mvsas driver may not.
> > > 
> > > I posted a patch yesterday to prevent such access to log pages not
> > supported
> > > by the device. See:
> > > 
> > > https://lore.kernel.org/linux-ide/20211115060559.232835-1-damien.
> > > lemoal@opensource.wdc.com/
> > > 
> > > Can you try these ?
> > > 
> > > 
> > > > 
> > > > This commit: 2360fa1812cd ("libata: cleanup NCQ priority handling")?
> > > > 
> > > > Damien, can you take a look?
> > 
> > I will try rebuilding with the patches at my first opportunity and report
> > back.
> 
> That would be great. Thanks.

Looks like your hunch may have been right on. I applied your patches to a fresh
copy of the 5.15.2 source (which was not working properly with my RR 2744 card
via the mvsas driver in vanilla form), and the issue did not arise when I
booted into it.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.