[Bug 215993] Serial Bus Multi Instantiate driver fails to allocate SPI device CSC3551:00

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=215993

--- Comment #21 from Andy Shevchenko (andy.shevchenko@gmail.com) ---
(In reply to Supasak Sutha from comment #20)
> Actually I have been try this patch 
> 
> https://lore.kernel.org/all/20220703053225.2203-1-xw897002528@gmail.com/
> 
> and get pass this line 
> 
> https://elixir.bootlin.com/linux/v5.19-rc4/source/sound/pci/hda/cs35l41_hda.
> c#L423
> 
> but still got error (below).
> 
> So, I revert that patch

I believe that patch is legit and it's okay to have it.

> and try yours (remove those 2 lines and replace
> cs35l41->index = id).

But you would still need the above change, because for SPI it's a chip select 0
or 1, and not an address (which is 0x40 in i2c case). 

> And still got same result which is:
> 
> [15.94] cs35l41-hda spi0-CSC3551:00-cs35l41-hda.1: Failed waiting for
> OTP_BOOT_DONE: -110.
> 
> from 
> 
> https://elixir.bootlin.com/linux/v5.19-rc4/source/sound/pci/hda/cs35l41_hda.
> c#L488

A-ha, this may give another clue. The GPIOs are addressed by index from _CRS
and it may be that the 0 is wrong (and actually it might be two different GPIOs
for reset of each of the codecs).

https://elixir.bootlin.com/linux/v5.19-rc4/source/sound/pci/hda/cs35l41_hda.c#L430

In this line, try to replace 0 by a) id or b) id + 1 and see if it helps
anyhow.

Ideally we need a PCB schematics of that laptop. With it at hand it will be 15
minutes work to understand GPIO mappings. Any possibility to get schematics?

> **
> And I also tried this quirk and not working.

That quirk is for a LED, I don't think it's anyhow critical right now.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.