[Bug 216033] KVM VMX nested virtualization: VMXON does not check guest CR0 against IA32_VMX_CR0_FIXED0

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=216033

--- Comment #4 from Eric Li (ercli@ucdavis.edu) ---
>       if (!nested_host_cr0_valid(vcpu, kvm_read_cr0(vcpu)) ||
>           !nested_host_cr4_valid(vcpu, kvm_read_cr4(vcpu))) {
>               kvm_queue_exception(vcpu, UD_VECTOR);
>               return 1;
>       }

Thanks for the reply. I think there is still a typo. Do you mean the following?

        if (!nested_host_cr0_valid(vcpu, kvm_read_cr0(vcpu)) ||
            !nested_host_cr4_valid(vcpu, kvm_read_cr4(vcpu))) {
                kvm_queue_exception_e(vcpu, GP_VECTOR, 0);
                return 1;
        }

Or maybe:

        if (!nested_host_cr0_valid(vcpu, kvm_read_cr0(vcpu)) ||
            !nested_host_cr4_valid(vcpu, kvm_read_cr4(vcpu))) {
                kvm_inject_gp(vcpu, 0);
                return 1;
        }

I am not familiar with KVM code so not sure which one should be used. Thanks
again!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.