[Bug 216863] ThinkPad X1 Extreme Gen 5: PCIe Bus Error: severity=Corrected, type=Data Link Layer, (Transmitter ID) after resuming from sleep

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=216863

--- Comment #2 from Frederick Zhang (frederick888@tsundere.moe) ---
I just realised that pcie_aspm=off broke most of my dock's functions. I
still had Ethernet but wake-on-lan stopped working. The dock's
Thunderbolt ports, USB Type-A/C data ports, SD card slots all stopped
working too (no logs at all after plugging in things).

Then I tested pcie_aspm.policy=performance. The dock started working
again but the warning logs were also back.

Also tried applying quirk_disable_aspm_l0s_l1 on the Thunderbolt bridges
but unfortunately I still had the logs.

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 285acc4aaccc..495e976606b6 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2393,8 +2393,11 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev
*dev)
  * disable both L0s and L1 for now to be safe.
  */
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080,
quirk_disable_aspm_l0s_l1);

+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x1136,
quirk_disable_aspm_l0s_l1);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x0b26,
quirk_disable_aspm_l0s_l1);
+
 /*
  * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain
  * Link bit cleared after starting the link retrain process to allow this
  * process to finish.

And I noticed that the warning logs stopped once I plugged something in
(NVMe enclosure or SD card), and started again once I ran `udisksctl
power-off`. This was without any parameters or patches.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.