From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 151FBC3DA78 for ; Tue, 17 Jan 2023 15:47:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60D8610E4A7; Tue, 17 Jan 2023 15:46:59 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42F2410E4A7 for ; Tue, 17 Jan 2023 15:46:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7EBDD61491 for ; Tue, 17 Jan 2023 15:46:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id E2BA6C433EF for ; Tue, 17 Jan 2023 15:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673970415; bh=T/1bNzzjOvrSpvHMQJn0UeTgBm5IZL3GD+3L7O0MMSE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=pvwDoJW7duWgOErhzi2LORNPvi9ot4xoRYZ9uPWcY188KW94l1HGjHLgowZkEFQSo G6xF169y3mpYJ/nUeMurXqGgZp0Drf3e3gSW50D7QLtZgRZ8V++kBY7JhYN5+P1WN4 gUrjW3agNQJaKcA5Yz53NFns1jICHoXzmwQs+LuyKULB53SNIm74r6HMN3YjIf81cg aw3RKIrEKw1RJuv9cNJI3Vy+ZnAcBLQV/aCydyT6tfRThFUI3VA7e1TCE7d4yHohNv i3lWtgzxsafg3zHY/o8WpFcox+TN68lEkmG/m3biWIGhd7J9+HCVUo8IAm9b7y01Wq jL7d9wqzfY72w== Received: by aws-us-west-2-korg-bugzilla-1.web.codeaurora.org (Postfix, from userid 48) id C7E3AC43142; Tue, 17 Jan 2023 15:46:55 +0000 (UTC) From: bugzilla-daemon@kernel.org To: dri-devel@lists.freedesktop.org Subject: [Bug 216917] hibernation regression since 6.0.18 (Ryzen-5650U incl. Radeon GPU) Date: Tue, 17 Jan 2023 15:46:55 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo drivers_video-dri@kernel-bugs.osdl.org X-Bugzilla-Product: Drivers X-Bugzilla-Component: Video(DRI - non Intel) X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: alexdeucher@gmail.com X-Bugzilla-Status: NEEDINFO X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: drivers_video-dri@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" https://bugzilla.kernel.org/show_bug.cgi?id=3D216917 --- Comment #26 from Alex Deucher (alexdeucher@gmail.com) --- (In reply to Rainer Fiebig from comment #25) > (In reply to Alex Deucher from comment #23) > > I'll just revert it. It is more important for kernels with the the > > drm_buddy changes. >=20 > Would the following be equivalent to what you intended with your commit? > Looks a bit awkward but hibernate/resume work with it for 6.0.19 (and a > Ryzen 5600G): >=20 >=20 > uint32_t amdgpu_bo_get_preferred_domain(struct amdgpu_device *adev, > uint32_t domain) > { > if (domain =3D=3D (AMDGPU_GEM_DOMAIN_VRAM | AMDGPU_GEM_DOMAIN_GTT))= { > domain =3D AMDGPU_GEM_DOMAIN_VRAM; > if ((adev->asic_type =3D=3D CHIP_CARRIZO) || (adev->asic_ty= pe =3D=3D > CHIP_STONEY)) > { > if (adev->gmc.real_vram_size <=3D AMDGPU_SG_THRESHO= LD) > domain =3D AMDGPU_GEM_DOMAIN_GTT; > } > } > return domain; > } >=20 >=20 > Let me know whether this is worth persuing. I could then test it with > 5.15.88 and 6.1.6. Nope. What my patch does is allow display buffers to be in either system memory (GTT) or carve out (VRAM) depending on what is available. Without t= he patch, the driver picks either VRAM or GTT depending on how much VRAM is available on the system. This can lead to memory exhaustion in some cases = with multiple large resolution monitors depending on memory fragmentation. What your patch does is just always use VRAM unless the chip is Carrizo or Stoney. So it is effectively just reverting the commit (depending on how m= uch VRAM your system has). --=20 You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.=