All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@kernel.org
To: linux-usb@vger.kernel.org
Subject: [Bug 217242] CPU hard lockup related to xhci/dma
Date: Thu, 13 Apr 2023 08:02:29 +0000	[thread overview]
Message-ID: <bug-217242-208809-oCDwpjF8CP@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-217242-208809@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=217242

--- Comment #17 from Mathias Nyman (mathias.nyman@linux.intel.com) ---
Thanks, one reason why ring expansion calculation is incorrect is that we try
to store a negative value in an unsigned int. 

static int prepare_ring(...)
{
        unsigned int num_trbs_needed;        
        ....
        num_trbs_needed = num_trbs - ep_ring->num_trbs_free;
}

ep_ring->num_trbs_free might be bigger than num_trbs

So we end up with a huge and incorrect num_trbs_needed

https://elixir.bootlin.com/linux/v6.2/source/drivers/usb/host/xhci-ring.c#L3186

In addition to this there is most likely a small bug in tracking
ep_ring->num_trbs_free, gradually decreasing it incorrectly.
Not sure where that happens

Still working on that debugging patch

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2023-04-13  8:02 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24 15:00 [Bug 217242] New: CPU hard lockup related to xhci/dma bugzilla-daemon
2023-04-01 20:49 ` [Bug 217242] " bugzilla-daemon
2023-04-01 20:54 ` bugzilla-daemon
2023-04-01 20:57 ` bugzilla-daemon
2023-04-01 22:11 ` bugzilla-daemon
2023-04-01 22:12 ` bugzilla-daemon
2023-04-01 22:17 ` bugzilla-daemon
2023-04-02 15:54   ` Hans Petter Selasky
2023-04-02 17:25     ` Greg KH
2023-04-02 18:57       ` Alan Stern
2023-04-05 18:15         ` Hans Petter Selasky
2023-04-02 15:54 ` bugzilla-daemon
2023-04-02 17:25 ` bugzilla-daemon
2023-04-03 19:18 ` bugzilla-daemon
2023-04-06 20:15 ` bugzilla-daemon
2023-04-06 20:16 ` bugzilla-daemon
2023-04-10 17:32 ` bugzilla-daemon
2023-04-10 17:34 ` bugzilla-daemon
2023-04-11 12:54 ` bugzilla-daemon
2023-04-12 19:56 ` bugzilla-daemon
2023-04-12 19:57 ` bugzilla-daemon
2023-04-13  8:02 ` bugzilla-daemon [this message]
2023-04-13 20:23 ` bugzilla-daemon
2023-04-14 14:24 ` bugzilla-daemon
2023-04-14 14:32 ` bugzilla-daemon
2023-04-14 20:02 ` bugzilla-daemon
2023-04-18 19:24 ` bugzilla-daemon
2023-04-18 20:17 ` bugzilla-daemon
2023-04-19 15:41 ` bugzilla-daemon
2023-04-19 15:44 ` bugzilla-daemon
2023-04-19 18:41 ` bugzilla-daemon
2023-04-19 18:45 ` bugzilla-daemon
2023-04-21 17:54 ` bugzilla-daemon
2023-04-25 14:35 ` bugzilla-daemon
2023-04-25 19:01 ` bugzilla-daemon
2023-04-26 15:18 ` bugzilla-daemon
2023-04-26 15:20 ` bugzilla-daemon
2023-04-27 20:37 ` bugzilla-daemon
2023-05-05 18:50 ` bugzilla-daemon
2023-05-08  7:54 ` bugzilla-daemon
2023-05-08 11:46 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-217242-208809-oCDwpjF8CP@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.