All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@kernel.org
To: platform-driver-x86@vger.kernel.org
Subject: [Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf
Date: Wed, 10 Apr 2024 04:49:21 +0000	[thread overview]
Message-ID: <bug-218685-215701-Y00DcBTTzf@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-218685-215701@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=218685

--- Comment #13 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
OK, from that log and your acpidump it looks to me that it supports these PMF
functions:

APMF_FUNC_GET_SYS_PARAMS
APMF_FUNC_SBIOS_REQUESTS
APMF_FUNC_OS_POWER_SLIDER_UPDATE


The one that is specifically causing the conflict the ASUS driver is
APMF_FUNC_OS_POWER_SLIDER_UPDATE.  This is what causes the ACPI power profile
to get registered:

[   71.242252] amd-pmf AMDI0102:00: SPS enabled and Platform Profiles
registered

When the profile is moved it calls APMF() with an arg of 8, which calls PMF8():

                    Case (0x08)
                    {
                        PMF8 (Arg1)
                    }

PMF8 outputs some debug using M460 but eventually calls APX8():

            Method (PMF8, 1, Serialized)
            {
                M460 ("FEA-ASL-\\_SB.PMF.APMF Function 8 call PMF8\n", Zero,
Zero, Zero, Zero, Zero, Zero)
                CreateByteField (Arg0, 0x02, M490)
                M460 ("  Slider Event Notification: 0x%x\n", M490, Zero, Zero,
Zero, Zero, Zero)
                If (CondRefOf (\_SB.APX8))
                {
                    M460 ("  Call OEM ACPI APX8\n", Zero, Zero, Zero, Zero,
Zero, Zero)
                    \_SB.APX8 (M490)
                }
            }

This updates a "PMTP" field:

        Method (APX8, 1, Serialized)
        {
            PMTP = (0xD6080000 | Arg0)
        }

That PTMP field is part of an Operation Region used for Port I/O:

        OperationRegion (TP80, SystemIO, 0x80, 0x04)
        Field (TP80, DWordAcc, NoLock, Preserve)
        {
            PMTP,   32
        }

To me this looks like the system should probably be responding to power slider
events from the amd-pmf driver.  Do you find that various CPU coefficients
don't get updated even when you've changed the power profile when amd-pmf is
bound?

If they do get updated, then I think the bug should be in asus-wmi.c that it
shouldn't be loading a platform profile because amd-pmf is taking this role. 
Perhaps the DSTS method has an unknown bit to indicate this?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2024-04-10  4:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-218685-215701@https.bugzilla.kernel.org/>
2024-04-09 15:49 ` [Bug 218685] asus-nb-wmi fails to load due to conflict with amd-pmf bugzilla-daemon
2024-04-09 15:51 ` bugzilla-daemon
2024-04-09 15:57 ` bugzilla-daemon
2024-04-09 16:30 ` bugzilla-daemon
2024-04-10  1:15 ` bugzilla-daemon
2024-04-10  4:49 ` bugzilla-daemon [this message]
2024-04-10  5:03 ` bugzilla-daemon
2024-04-10  5:19 ` bugzilla-daemon
2024-04-10  5:29 ` bugzilla-daemon
2024-04-10  5:35 ` bugzilla-daemon
2024-04-10  5:35 ` bugzilla-daemon
2024-04-10  5:45 ` bugzilla-daemon
2024-04-10  6:05 ` bugzilla-daemon
2024-04-10  6:09 ` bugzilla-daemon
2024-04-10  6:10 ` bugzilla-daemon
2024-04-10 11:22 ` bugzilla-daemon
2024-04-10 11:24 ` bugzilla-daemon
2024-04-10 11:29 ` bugzilla-daemon
2024-04-10 11:30 ` bugzilla-daemon
2024-04-10 11:31 ` bugzilla-daemon
2024-04-10 11:35 ` bugzilla-daemon
2024-04-10 11:49 ` bugzilla-daemon
2024-04-10 11:52 ` bugzilla-daemon
2024-04-10 11:58 ` bugzilla-daemon
2024-04-10 12:28 ` bugzilla-daemon
2024-04-10 12:44 ` bugzilla-daemon
2024-04-10 14:24 ` bugzilla-daemon
2024-04-10 14:38 ` bugzilla-daemon
2024-04-10 14:45 ` bugzilla-daemon
2024-04-10 14:54 ` bugzilla-daemon
2024-04-10 15:22 ` bugzilla-daemon
2024-04-12  7:08 ` bugzilla-daemon
2024-04-12 11:21 ` bugzilla-daemon
2024-04-12 13:04 ` bugzilla-daemon
2024-04-12 13:32 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-218685-215701-Y00DcBTTzf@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.