All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon--- via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [Bug 219484] f2fs discard causes kernel NULL pointer dereferencing
Date: Sat, 09 Nov 2024 15:11:20 +0000	[thread overview]
Message-ID: <bug-219484-202145-LUIa9WRZgU@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-219484-202145@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=219484

Chao Yu (chao@kernel.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |chao@kernel.org

--- Comment #1 from Chao Yu (chao@kernel.org) ---
Hi, thanks for your report.

Can you please help to check max_hw_discard_sectors parameter of dm device
via "cat /sys/block/<device_name>/queue/max_hw_discard_sectors"?

I doubt max_discard_blocks becomes zero in __submit_discard_cmd(), result
in that __blkdev_issue_discard() fails to allocate bio.

__submit_discard_cmd()
{
        unsigned int max_discard_blocks =
                        SECTOR_TO_BLOCK(bdev_max_discard_sectors(bdev));
...
        while () {
...
                if (len > max_discard_blocks) {
                        len = max_discard_blocks;
                        last = false;
                }
...
                } else {
                        err = __blkdev_issue_discard(bdev,
                                        SECTOR_FROM_BLOCK(start),
                                        SECTOR_FROM_BLOCK(len),
                                        GFP_NOFS, &bio);
                }
...
                f2fs_bug_on(sbi, !bio); // trigger warning here and panic below
}

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2024-11-09 15:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09 12:01 [f2fs-dev] [Bug 219484] New: f2fs discard causes kernel NULL pointer dereferencing bugzilla-daemon--- via Linux-f2fs-devel
2024-11-09 15:11 ` bugzilla-daemon--- via Linux-f2fs-devel [this message]
2024-11-09 15:40 ` [f2fs-dev] [Bug 219484] " bugzilla-daemon--- via Linux-f2fs-devel
2024-11-10 11:36 ` bugzilla-daemon--- via Linux-f2fs-devel
2024-11-10 14:44 ` bugzilla-daemon--- via Linux-f2fs-devel
2024-11-10 15:42 ` bugzilla-daemon--- via Linux-f2fs-devel
2024-11-21  9:50 ` bugzilla-daemon--- via Linux-f2fs-devel
2024-11-21  9:54 ` bugzilla-daemon--- via Linux-f2fs-devel
2024-11-22 22:45 ` bugzilla-daemon--- via Linux-f2fs-devel
2024-12-12 18:57 ` bugzilla-daemon--- via Linux-f2fs-devel
2024-12-17 13:39 ` bugzilla-daemon--- via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-219484-202145-LUIa9WRZgU@https.bugzilla.kernel.org/ \
    --to=linux-f2fs-devel@lists.sourceforge.net \
    --cc=bugzilla-daemon@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.