[Bug 221184] mouse/keyboard (connected via hub) usb reset under system load with weak cpu

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=221184

--- Comment #34 from Liam Mitchell (mitchell.liam@gmail.com) ---
(In reply to Alan Stern from comment #33)
> One of Michał Pecio's points is that if you want to retry following a
> -EPROTO error, it is necessary to reset the endpoint first by calling
> usb_clear_halt() -- just like with a -EPIPE error.  I think usbhid may not
> do this; if it doesn't then it needs to be fixed.

That doesn't match what I'm reading.

In Documentation/driver-api/usb/error-codes.rst:
> -EPIPE Endpoint stalled. For non-control endpoints, reset this status with
> usb_clear_halt().

From what I understand "stalled" is a device state and requires communication
with the device to clear.

EPROTO/EILSEQ are host controller errors representing communication failure.
They can't be fixed, only acknowledged and retried. Calling usb_clear_halt()
for these would unnecessarily delay retry.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.