[Bug 221383] ideapad_laptop: Fn hotkeys stop emitting after s2idle resume on IdeaPad Slim 3 14ARP10 (Ryzen 7735HS)

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=221383

--- Comment #49 from Daniel Gibson (metalcaedes@gmail.com) ---
> Try using DMI_PRODUCT_NAME like the other Lenovo systems.  This should match
> whole generations hopefully.

As far as I can tell it doesn't. For my 16ABR8 it's 82XR, the dmesg log of
https://bugzilla.kernel.org/show_bug.cgi?id=220521 mentions 82XM, which seems
to be 15ABR8 (says
https://download.lenovo.com/consumer/mobiles_pub/ideapad_slim_3_hmm.pdf), so
presumably the last char of the product name is the screen size.

I guess matching "IdeaPad Slim 3" + "ABR8" is safer than matching "82X".

> As for the other ideapad-laptop question, you need to talk to the authors of
> that module.

Sorry, I didn't mean to add anything to that module. It was just an example of
a module having a parameter that works around hardware bugs with a description
that explicitly asks users to report their hardware so it can be added to the
quirks list (or at least that's my assumption why they ask for it).

My question is: Do you think

  static int delay_suspend = -1;
  module_param(delay_suspend, int, 0644)
  MODULE_PARM_DESC(delay_suspend,
        "Delays s2idle by 2.5 seconds to work around buggy ECs, often causing
keyboard issues after suspend. "
        "0: don't delay, 1: do delay, -1 (default): let amd_pmc decide. "
        "If you need this please report this to:
platform-driver-x86@vger.kernel.org");

makes sense?
(I guess it would be the same e-mail address, as this bugreport goes to that
list as well.)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.