From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 22576] [KMS] mesa demo spectex broken on rv280 Date: Mon, 10 Dec 2012 16:37:52 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0243114022==" Return-path: Received: from culpepper.freedesktop.org (unknown [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 27F03E5DFE for ; Mon, 10 Dec 2012 08:37:52 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0243114022== Content-Type: multipart/alternative; boundary="1355157472.CB7bd251.16137"; charset="us-ascii" --1355157472.CB7bd251.16137 Date: Mon, 10 Dec 2012 16:37:52 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=22576 Roland Scheidegger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #21 from Roland Scheidegger --- (In reply to comment #18) > I think i've found source of these lighting problems on r200 in this and > other bugs. It is just a typo it seems in r200_state_init.c lit_emit() > > OUT_VEC(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1); > > instead of OUT_VEC it needs to be OUT_SCL: > > OUT_SCL(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1); Should be fixed by 320d531373e7b0873f5de42f6173b986290f593f, thanks! FWIW the command emit mechanism looks a bit too complicated it could profit from some refactoring. For instance it is still based on the fake drm_radeon_cmd_header_t structure, the scl vs. scl2 and vec vs. veclinear emits are nothing but crude hacks around limitations in that structure, even though since ums is gone there is absolutely no point in using that struct... Section size calcs are also somewhat confusing, the sanity code (which was really great back then) is totally unused etc. Maybe another day... -- You are receiving this mail because: You are the assignee for the bug. --1355157472.CB7bd251.16137 Date: Mon, 10 Dec 2012 16:37:52 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" changed bug 22576
What Removed Added
Status REOPENED RESOLVED
Resolution --- FIXED

Comment # 21 on bug 22576 from 
(In reply to comment #18)
>  I think i've found source of these lighting problems on r200 in this and
> other bugs. It is just a typo it seems in r200_state_init.c lit_emit()
> 
>  OUT_VEC(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1);
> 
>  instead of OUT_VEC it needs to be OUT_SCL:
> 
>  OUT_SCL(atom->cmd[LIT_CMD_1], atom->cmd+LIT_CMD_1+1);

Should be fixed by 320d531373e7b0873f5de42f6173b986290f593f, thanks!
FWIW the command emit mechanism looks a bit too complicated it could profit
from some refactoring. For instance it is still based on the fake
drm_radeon_cmd_header_t structure, the scl vs. scl2 and vec vs. veclinear emits
are nothing but crude hacks around limitations in that structure, even though
since ums is gone there is absolutely no point in using that struct...
Section size calcs are also somewhat confusing, the sanity code (which was
really great back then) is totally unused etc.
Maybe another day...

You are receiving this mail because:
  • You are the assignee for the bug.
--1355157472.CB7bd251.16137-- --===============0243114022== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0243114022==--