All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 26] Ixgbe driver does not ensure FWSM firmware mode is valid before using it
Date: Sun, 01 Apr 2018 13:43:13 +0000	[thread overview]
Message-ID: <bug-26-3@http.dpdk.org/tracker/> (raw)

https://dpdk.org/tracker/show_bug.cgi?id=26

            Bug ID: 26
           Summary: Ixgbe driver does not ensure FWSM firmware mode is
                    valid before using it
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: solal.pirelli@gmail.com
  Target Milestone: ---

The Intel 82599 data sheet
(https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/82599-10-gbe-controller-datasheet.pdf,
§8.2.3.4.10) states of the FWSM register's bit 15 (FW_Val_bit) that "Hardware
clears this bit in reset de-assertion so software can know firmware mode (bits
1-5) is invalid".

However, the ixgbe driver does not check that bit before using the firmware
mode, e.g. in ixgbe_mng_present
(http://dpdk.org/browse/dpdk/tree/drivers/net/ixgbe/base/ixgbe_common.c?h=v18.02#n5194).

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2018-04-01 13:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26-3@http.dpdk.org/tracker/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.