All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 35] Does not compile with musl libc: drivers/bus/pci/linux/pci_uio.c
Date: Thu, 03 May 2018 10:33:14 +0000	[thread overview]
Message-ID: <bug-35-3@http.dpdk.org/tracker/> (raw)

https://dpdk.org/tracker/show_bug.cgi?id=35

            Bug ID: 35
           Summary: Does not compile with musl libc:
                    drivers/bus/pci/linux/pci_uio.c
           Product: DPDK
           Version: 18.05
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: dpdk@stormmq.com
  Target Milestone: ---

This does not compile on X86 because it assumes the presence of the glibc-only
functions `outl_p`, `outw_p` and `outb_p`. This can be fixed reliably for all c
libraries and operating systems by simply importing our own definitions, viz:-

```
#if defined(RTE_ARCH_X86)
#include <sys/io.h>

// Used in pci_uio_ioport_write, these functions are present in glibc
// in <sys/io.h> (without the pci_uio_ prefix) but not in the
// musl lib c.

static __inline void
pci_uio_outl_p(unsigned int value, unsigned short int port)
{
  __asm__ __volatile__ ("outl %0,%w1\noutb %%al,$0x80": :"a" (value),
                        "Nd" (port));
}

static __inline void
pci_uio_outw_p(unsigned short int value, unsigned short int port)
{
  __asm__ __volatile__ ("outw %w0,%w1\noutb %%al,$0x80": :"a" (value),
                        "Nd" (port));
}

static __inline void
pci_uio_outb_p(unsigned char value, unsigned short int port)
{
  __asm__ __volatile__ ("outb %b0,%w1\noutb %%al,$0x80": :"a" (value),
                        "Nd" (port));
}
```

And then prefixing the usages of the glibc-only functions with `pci_uio_`, eg
`outl_p` becomes `pci_uio_outlw_p`.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2018-05-03 10:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-35-3@http.dpdk.org/tracker/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.