From: bugzilla-daemon@bugzilla.kernel.org
To: linux-scsi@vger.kernel.org
Subject: [Bug 49461] scsi/bfa/bfad.c:1037: possible off by one in strncpy ?
Date: Thu, 29 Aug 2013 04:44:20 +0000 [thread overview]
Message-ID: <bug-49461-11613-BVHvGKcJEq@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-49461-11613@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=49461
Jeff Zhou <jz.researcher@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jz.researcher@yahoo.com
--- Comment #1 from Jeff Zhou <jz.researcher@yahoo.com> ---
In 3.10.9, it is correct:
scsi/bfa/bfad.c : 1036
strncpy(driver_info.os_device_name, bfad->pci_name,
sizeof(driver_info.os_device_name) - 1);
scsi/bfa/bfad.c : 1014
struct bfa_fcs_driver_info_s driver_info;
scsi/bfa/bfa_fcs.h : 672
struct bfa_fcs_driver_info_s {
u8 version[BFA_VERSION_LEN]; /* Driver Version */
u8 host_machine_name[BFA_FCS_OS_STR_LEN];
u8 host_os_name[BFA_FCS_OS_STR_LEN]; /* OS name and version */
u8 host_os_patch[BFA_FCS_OS_STR_LEN]; /* patch or service pack */
u8 os_device_name[BFA_FCS_OS_STR_LEN]; /* Driver Device Name */
};
The copy length here is (BFA_FCS_OS_STR_LEN - 1), which should be.
--
You are receiving this mail because:
You are the assignee for the bug.
next prev parent reply other threads:[~2013-08-29 4:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-49461-11613@https.bugzilla.kernel.org/>
2012-10-25 10:51 ` [Bug 49461] scsi/bfa/bfad.c:1037: possible off by one in strncpy ? bugzilla-daemon
2013-08-29 4:44 ` bugzilla-daemon [this message]
2013-11-19 22:35 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-49461-11613-BVHvGKcJEq@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.