All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 506] i40e: Fix for rte_eth_dev_get_module_eeprom()
Date: Fri, 10 Jul 2020 09:10:16 +0000	[thread overview]
Message-ID: <bug-506-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=506

            Bug ID: 506
           Summary: i40e: Fix for rte_eth_dev_get_module_eeprom()
           Product: DPDK
           Version: 20.05
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: frederic.coiffier@6cure.com
  Target Milestone: ---

In DPDK 20.05 (and maybe previous versions), the
rte_eth_dev_get_module_eeprom() returns 512 bytes but all bytes are equal to
0x04.

Therefore, using the official Intel i40e 2.11.29 with ethtool -m works fine.

By comparing the 2 source code, we found a small typo in
i40e_get_module_eeprom():

- i40e-2.11.29:

                status = i40e_aq_get_phy_register(hw,
                                I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
                                addr, true, offset, &value, NULL);

- DPDK 20.05:

                status = i40e_aq_get_phy_register(hw,
                                I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
                                addr, offset, 1, &value, NULL);

By swapping offset and 1 in the DPDK source code, the
rte_eth_dev_get_module_eeprom() function works fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2020-07-10  9:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-506-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.