From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org Subject: [Bug 55310] New: incorrect rendering of some borders in certain gtk3 themes Date: Tue, 25 Sep 2012 09:34:00 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1202255849==" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org --===============1202255849== Content-Type: multipart/alternative; boundary="1348565641.eC5b1.20369"; charset="us-ascii" --1348565641.eC5b1.20369 Date: Tue, 25 Sep 2012 09:34:00 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" https://bugs.freedesktop.org/show_bug.cgi?id=55310 Priority: medium Bug ID: 55310 Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Summary: incorrect rendering of some borders in certain gtk3 themes QA Contact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org Severity: normal Classification: Unclassified OS: All Reporter: sebastian-keller-Mmb7MZpHnFY@public.gmane.org Hardware: Other Status: NEW Version: unspecified Component: Driver/nouveau Product: xorg Created attachment 67669 --> https://bugs.freedesktop.org/attachment.cgi?id=67669&action=edit Screenshot showing the problem When using a gtk3 theme that uses "border-image" with the "stretch" as repeat mode (such as Adwaita, the default theme), gtk3 uses cairo to scale the image. When using the "image" backend of cairo everything looks as expected. Using the X backend on a "intel" driver should work as well (as I'm told). But using the "nouveau" driver gives some fading out borders. After changing NV50EXAPictTexture to use CLAMP_TO_EDGE for RepeatPad like the intel driver does (http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/i915_render.c?id=c6008068372709c73034163eddc902b47bf87d24#n327) the result looks like the one rendered with the "image" backend. I'm attaching the patch and a screenshot that shows the rendering issue, how it looks with the image backend and after the patch. For the screenshot I've made the top right pixel in the top border red (#ff0000). In the first screenshot you can see how the color "fades away" because it gets blended with some transparent pixels when scaled. In the second and third screenshot the rightmost pixel before the corner is #ff0000. I've only tested the patch for nv50 but the nv40 one should work as well if the defines are correct. -- You are receiving this mail because: You are the assignee for the bug. --1348565641.eC5b1.20369 Date: Tue, 25 Sep 2012 09:34:00 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8"
Priority medium
Bug ID 55310
Assignee nouveau@lists.freedesktop.org
Summary incorrect rendering of some borders in certain gtk3 themes
QA Contact xorg-team@lists.x.org
Severity normal
Classification Unclassified
OS All
Reporter sebastian-keller@gmx.de
Hardware Other
Status NEW
Version unspecified
Component Driver/nouveau
Product xorg

Created attachment 67669 [details]
Screenshot showing the problem

When using a gtk3 theme that uses "border-image" with the "stretch" as repeat
mode (such as Adwaita, the default theme), gtk3 uses cairo to scale the image.
When using the "image" backend of cairo everything looks as expected. Using the
X backend on a "intel" driver should work as well (as I'm told). But using the
"nouveau" driver gives some fading out borders.

After changing NV50EXAPictTexture to use CLAMP_TO_EDGE for RepeatPad like the
intel driver does
(http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/i915_render.c?id=c6008068372709c73034163eddc902b47bf87d24#n327)
the result looks like the one rendered with the "image" backend.

I'm attaching the patch and a screenshot that shows the rendering issue, how it
looks with the image backend and after the patch.

For the screenshot I've made the top right pixel in the top border red
(#ff0000). In the first screenshot you can see how the color "fades away"
because it gets blended with some transparent pixels when scaled. In the second
and third screenshot the rightmost pixel before the corner is #ff0000.

I've only tested the patch for nv50 but the nv40 one should work as well if the
defines are correct.


You are receiving this mail because:
  • You are the assignee for the bug.
--1348565641.eC5b1.20369-- --===============1202255849== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Nouveau mailing list Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org http://lists.freedesktop.org/mailman/listinfo/nouveau --===============1202255849==--