All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: cpufreq@vger.kernel.org
Subject: [Bug 64271] Intel Pstate driver - "kick" code is not needed
Date: Mon, 04 Nov 2013 17:01:13 +0000	[thread overview]
Message-ID: <bug-64271-12968-Dgta1WV7rc@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-64271-12968@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=64271

--- Comment #4 from Dirk Brandewie <dirk.brandewie@gmail.com> ---
Here is the patch I will send upstream it may not make it until v3.14-rc1 since
the merge window is upon us :-)

commit 7d9aba45dbd356686eca097b31028eccec0e11d6
Author: Dirk Brandewie <dirk.j.brandewie@intel.com>
Date:   Mon Oct 14 07:54:45 2013 -0700

    cpufreq/intel_pstate: Remove periodic P state boost

    Remove the periodic P state boost.  This code required for some corner
    case benchmark tests.  The calculation of the required P state was
    incorrect/inaccurate and would not allow P state increase.

    This was fixed by a combination of commits:
      2134ed4 cpufreq / intel_pstate: Change to scale off of max P-state
      d253d2a intel_pstate: Improve accuracy by not truncating until final
result

    Fixes Bug:
      https://bugzilla.kernel.org/show_bug.cgi?id=64271

    Reported-by: dsmythies@telus.net
    Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
---
 drivers/cpufreq/intel_pstate.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 26ab4b8..4d07ae2 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -83,8 +83,6 @@ struct cpudata {
     struct pstate_data pstate;
     struct _pid pid;

-    int min_pstate_count;
-
     u64    prev_aperf;
     u64    prev_mperf;
     int    sample_ptr;
@@ -567,15 +565,6 @@ static void intel_pstate_timer_func(unsigned long __data)

     intel_pstate_sample(cpu);
     intel_pstate_adjust_busy_pstate(cpu);
-
-    if (cpu->pstate.current_pstate == cpu->pstate.min_pstate) {
-        cpu->min_pstate_count++;
-        if (!(cpu->min_pstate_count % 5)) {
-            intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate);
-        }
-    } else
-        cpu->min_pstate_count = 0;
-
     intel_pstate_set_sample_time(cpu);
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.

  parent reply	other threads:[~2013-11-04 17:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 22:17 [Bug 64271] New: Intel Pstate driver - "kick" code is not needed bugzilla-daemon
2013-11-03 21:13 ` [Bug 64271] " bugzilla-daemon
2013-11-04 16:17 ` bugzilla-daemon
2013-11-04 16:42 ` bugzilla-daemon
2013-11-04 17:01 ` bugzilla-daemon [this message]
2013-11-05 23:12 ` bugzilla-daemon
2014-04-15  6:30 ` bugzilla-daemon
2014-04-15  6:30 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64271-12968-Dgta1WV7rc@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=cpufreq@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.